control_exchange is dupplicated

Bug #1266259 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Undecided
Emilien Macchi
Havana
Fix Released
Undecided
Unassigned

Bug Description

control_exchange is duplicated in init.pp and ceilometer.pp

When I declare 'cinder' and 'cinder::ceilometer' classes on same node, it fails:
Duplicate declaration: Cinder_config[DEFAULT/control_exchange] is already declared in file /home/emilien/Git/eNovance/puppet-privatecloud/spec/fixtures/modules/cinder/manifests/init.pp:91; cannot redeclare at /home/emilien/Git/eNovance/puppet-privatecloud/spec/fixtures/modules/cinder/manifests/ceilometer.pp:24

Let the flag in init.pp is I think the solution.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/65008

Changed in puppet-cinder:
assignee: nobody → Emilien Macchi (emilienm)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/65008
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=bb977b42d526c7252817aca85dd2b350236111e8
Submitter: Jenkins
Branch: master

commit bb977b42d526c7252817aca85dd2b350236111e8
Author: Emilien Macchi <email address hidden>
Date: Sun Jan 5 20:09:57 2014 +0100

    Delete control_exchange flag

    control_exchange is duplicated in init.pp and ceilometer.pp which could
    create duplicate declaration when declaring cinder and
    cinder::ceilometer on same node.

    Closes-bug #1266259
    Signed-off-by: Emilien Macchi <email address hidden>

    Change-Id: Ic1c5c880c421f43d2a125b2b5b58630fc55bc9c8

Changed in puppet-cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/65693

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/havana)

Reviewed: https://review.openstack.org/65693
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=99a116d6adc5131a7dc43f13e709622a286dfdff
Submitter: Jenkins
Branch: stable/havana

commit 99a116d6adc5131a7dc43f13e709622a286dfdff
Author: Emilien Macchi <email address hidden>
Date: Sun Jan 5 20:09:57 2014 +0100

    Delete control_exchange flag

    control_exchange is duplicated in init.pp and ceilometer.pp which could
    create duplicate declaration when declaring cinder and
    cinder::ceilometer on same node.

    Closes-bug #1266259

    Signed-off-by: Emilien Macchi <email address hidden>
    Change-Id: Ic1c5c880c421f43d2a125b2b5b58630fc55bc9c8
    (cherry picked from commit bb977b42d526c7252817aca85dd2b350236111e8)

tags: added: in-stable-havana
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
milestone: none → 4.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.