puppet-ceph

Add option to make rbd_default_features user settable

Bug #1633552 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceph
In Progress
Undecided
Unassigned

Bug Description

Operators deploying Ceph Jewel clients may need to have those clients use older Ceph servers. To resolve this ceph clients just need "rbd default features = 1" in the [client] section of their ceph.conf. This bug requests that this be a user settable option. Some distributions ship Jewel clients by default and this change is necessary to make them backwards compatible with different version Ceph servers.

John Fulton (jfulton-org)
Changed in puppet-ceph:
assignee: nobody → John Fulton (jfulton-org)
OpenStack Infra (hudson-openstack)
Changed in puppet-ceph:
status: New → In Progress
Revision history for this message
John Fulton (jfulton-org) wrote :

After applying the changes from the following two upstream patches:

 https://review.openstack.org/386972
 https://review.openstack.org/283359

and adding the following to my Heat environment file:

  ExtraConfig:
    ceph::profile::params::rbd_default_features: '1'

I was able to get a deploy with the following ceph.conf on my compute node (a ceph client):

[root@overcloud-novacompute-0 ~]# cat /etc/ceph/ceph.conf

[global]
osd_pool_default_min_size = 1
auth_service_required = cephx
mon_initial_members = overcloud-controller-0,overcloud-controller-1,overcloud-controller-2
fsid = 63089b2a-930d-11e6-aba5-525400330666
cluster_network = 192.168.1.26/24
auth_supported = cephx
auth_cluster_required = cephx
mon_host = 172.16.1.23,172.16.1.16,172.16.1.24
auth_client_required = cephx
public_network = 172.16.1.18/24

[client]
rbd_default_features = 1
[root@overcloud-novacompute-0 ~]#

OpenStack Infra (hudson-openstack)
Changed in puppet-ceph:
assignee: John Fulton (jfulton-org) → Andrew Woodward (xarses)
OpenStack Infra (hudson-openstack)
Changed in puppet-ceph:
assignee: Andrew Woodward (xarses) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-ceph (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/283359
Reason: no efforts to make it working, i'll abandon it again. Feel free to ping me if you want it again.

OpenStack Infra (hudson-openstack)
Changed in puppet-ceph:
assignee: Emilien Macchi (emilienm) → John Fulton (jfulton-org)
Revision history for this message
John Fulton (jfulton-org) wrote :

The following changes to fix this bug are now in and all have +1's from Jenkins and some +2s from Emilien. They just need to be voted in so they can merge and the bug can be closed.

https://review.openstack.org/#/c/283359/
https://review.openstack.org/#/c/420105/
https://review.openstack.org/#/c/420166/
https://review.openstack.org/#/c/386972/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceph (master)

Reviewed: https://review.openstack.org/283359
Committed: https://git.openstack.org/cgit/openstack/puppet-ceph/commit/?id=8e01a414312ff0387f3847a1b8fb2a9bdc828b16
Submitter: Jenkins
Branch: master

commit 8e01a414312ff0387f3847a1b8fb2a9bdc828b16
Author: John Fulton <email address hidden>
Date: Sat Oct 15 16:30:56 2016 -0400

    init: allow to configure rbd_default_features

    Allow puppet-ceph to configure rbd_default_features parameter in
    ceph.conf / [client] section. Operators deploying newer Ceph clients
    that must use older Ceph servers need to be able to easily set this
    option for backwards compatibility.

    Depends-On: I3242cfe0f141fe2bbb951ce2cf7071fd07456db8
    Change-Id: I477640c5db2cc84622da7734fb54cfe7740bd137
    Partial-Bug: 1633552

John Fulton (jfulton-org)
Changed in puppet-ceph:
assignee: John Fulton (jfulton-org) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.