PQM

When PQM is put into RC-only mode it should still process branches that were submitted before it went RC-only

Bug #223790 reported by Graham Binns
2
Affects Status Importance Assigned to Milestone
PQM
Confirmed
Wishlist
Unassigned

Bug Description

After having four branches, which were submitted well before the non-RC window closed on Sunday evening, bounce because they weren't marked as RC, I've been thinking: Why does going RC-only work the way it does?

Here's the way I currently see the process, from my admittedly limited point of view as one of PQM's frequent victims:

 1. Friday, week 3: I submit a branch.
 2. Saturday, week 3: It bounces, possibly with a comic "twang" of someone's
 braces snapping.
 3. Sunday AM, week 4: I resubmit it.
 4. Sunday, 19:00 UTC, week 4: PQM goes RC-only.
 5. Sunday, 19:01 UTC, week 4: PQM processes my branch, and spits it back
 because it's not RC only.

They way I see it, PQM should work like this:

 1. Friday, week 3: I submit a branch.
 2. Saturday, week 3: It bounces. Hilarity ensues.
 3. Sunday AM, week 4: I resubmit it.
 4. Sunday, 19:00 UTC, week 4: PQM goes RC-only.
 5. Sunday, 19:30 UTC, Launchpad developer Joe Soap submits a branch for
 processing.
 5. Sunday, 19:31 UTC, week 4: PQM processes my branch. Miraculously, it
 merges.
 6. Sunday, 20:51 UTC, week 4: PQM processes Joe's branch. Because it was
 submitted after the RC deadline it isn't valid and gets rejected.

Graham Binns (gmb)
description: updated
description: updated
Revision history for this message
Brad Crittenden (bac) wrote :

See also bug 110433

Revision history for this message
Dan Watkins (oddbloke) wrote :

How does LP switch between standard and RC-only mode?

There's no PQM code to do so, making it quite hard to work out what the bug here is.

Changed in pqm:
status: New → Incomplete
Revision history for this message
Tim Penhey (thumper) wrote :

This bug should not really be against PQM at all.

The workflow that Launchpad uses relies on messing around with the queue that PQM uses.

I am working on Launchpad hosted queues for PQM (honest), that will make this workflow work.

Revision history for this message
Dan Watkins (oddbloke) wrote :

Marking as Invalid for the time being. If a reason to reopen it comes up, please feel free to do so.

Changed in pqm:
status: Incomplete → Invalid
Revision history for this message
Robert Collins (lifeless) wrote :

the RC support is done by changing the precommit rules in both pqm and the project being merged against IIRC. pqm can probably assist by providing some data about the merge to the projects make file via e.g. environment variables.

Changed in pqm:
importance: Undecided → Wishlist
status: Invalid → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.