pqm-submit is sending messages pqm doesn't understand

Working on it, will be committed to trunk in a second (and pushed to the 0.92 branch)

Should this be a different bug which is just that PQM doesn't properly conform to the e-mail Subject spec?

It does look like a bug that the entire subject line from the first non-ASCII character got escaped. Is that an issue with the email module, or bzrlib?

Well, there are 2 bits.

1) It technically could have done:
    "(Adeodato =?UTF-8?B?U2l=) show (possibly dotted) revnos in `bzr tags`, allow to sort them by time"

And only encoded the single character that was not ascii.

I think the reason the whole string was encoded was because of the email module.

In fact, I'm surprised that the whole string wasn't one =?UTF-8?B?....=
I'm guessing that python2.4 would have done that, because that is the code I've looked at more.

In fact, with 2.4 I get
>>> msg = bzrlib.email_message.EmailMessage('joe@foo', ['joe@foo'], u'Testing \xe5')
>>> str(msg._headers['Subject'])
'=?utf-8?q?Testing_=C3=A5?='

This is because the quoted printable was shorter than the base64 encoded form. But if you put more characters in, that will eventually shift.

>>> msg = bzrlib.email_message.EmailMessage('joe@foo', ['joe@foo'], u'Testing \u062c\u0648\u062c\u0648')
>>> str(msg._headers['Subject'])
'=?utf-8?b?VGVzdGluZyDYrNmI2KzZiA==?='

2) PQM doesn't support any sort of quoting anyway. So regardless we need to send a raw UTF-8 Subject line, because that is what PQM expects.

I should also make it clear that officially to conform to the Email RFC 2231 we shouldn't be sending anything but ASCII or the properly =?UTF-8?...= encoded forms.

Which is what we upgraded bzrlib to do. But means that we need to downgrade pqm-submit, because pqm does not accept properly formed emails.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel пишет:
> Well, there are 2 bits.
>
> 1) It technically could have done:
> "(Adeodato =?UTF-8?B?U2l=) show (possibly dotted) revnos in `bzr tags`, allow to sort them by time"

Sorry guys about this subject line. It my fault and my thunderbird.
I generate that e-amil by hands and send via Thunderbird.
I don't use pqm-submit plugin.

Sorry again :-(
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHMVcJzYr338mxwCURAqDhAJ4hh/DpAhDYqeh4zZ7meARypwtp8gCeKaAn
OEfn0nrjLi2k5kkQZzhe5/w=
=g1wE
-----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> John A Meinel ?8H5B:
>> Well, there are 2 bits.
>
>> 1) It technically could have done:
>> "(Adeodato =?UTF-8?B?U2l=) show (possibly dotted) revnos in `bzr tags`, allow to sort them by time"
>
> Sorry guys about this subject line. It my fault and my thunderbird.
> I generate that e-amil by hands and send via Thunderbird.
> I don't use pqm-submit plugin.
>
> Sorry again :-(

Well, it is the same problem. But interestingly it was T-bird generating a
"correct but wrong for PQM" message.

It just happened to happen the day after I updated pqm-submit to make the same
mistake.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHMfzqJdeBCYSNAAMRAiNIAKCjqwyHWpq3I5Zz0+FTBgS2emQgKACfaaxM
LLDxzYqzfyVsamfbwzumJos=
=6ttl
-----END PGP SIGNATURE-----

On Wed, 2007-11-07 at 17:59 +0000, John A Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alexander Belchenko wrote:
> > John A Meinel ?8H5B:
> >> Well, there are 2 bits.
> >
> >> 1) It technically could have done:
> >> "(Adeodato =?UTF-8?B?U2l=) show (possibly dotted) revnos in `bzr tags`, allow to sort them by time"
> >
> > Sorry guys about this subject line. It my fault and my thunderbird.
> > I generate that e-amil by hands and send via Thunderbird.
> > I don't use pqm-submit plugin.
> >
> > Sorry again :-(

So Alexander, what can we do to pqm-submit, to make it more usable for
you - to make it your default choice to send merges?

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

I can't reproduce this. If someone finds a way to do it, reopen the bug.

pqm-submit has been crafted to no-longer send proper email subjects, I'm happy to switch it back if you need it for testing.

Basically, I hacked pqm-submit to workaround the problem with PQM.

I've found a way. Bug reopened. I'm going to have a look at this now.