Incomplete packages listing - bionic not included
Bug #2038651 reported by
Sebastien Bacher
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ppa-dev-tools |
Fix Committed
|
Medium
|
Bryce Harrington |
Bug Description
Using the 0.5 deb from the ppa
$ ppa tests --arch=amd64 ppa:seb128/
* Triggers:
- Source update-
+ Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
- Source update-
+ Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
* Results:
...
but
$ ppa tests --arch=amd64 -r bionic ppa:seb128/
* Triggers:
- Source update-
+ Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
the bionic version should have been included in the output of the call without a serie specified
Related branches
ppa-dev-tools:fix-lp2038651-bionic-not-included
- Sebastien Bacher (community): Approve
- Andreas Hasenack (community): Approve
- PpaDevTools Developers: Pending requested
- Canonical Server Reporter: Pending requested
-
Diff: 84 lines (+38/-3)2 files modifiedscripts/ppa (+1/-0)
tests/test_scripts_ppa.py (+37/-3)
summary: |
- Incomplete packages listing + Incomplete packages listing - bionic not included |
Changed in ppa-dev-tools: | |
assignee: | nobody → Bryce Harrington (bryce) |
Changed in ppa-dev-tools: | |
status: | Triaged → Fix Committed |
To post a comment you must log in.
Interesting, there seem to be various definitions of what "active" and "supported" mean.
Currently, what the code uses as the default is UbuntuDistroInfo's definition of "supported":
releases = config. get('releases' , None)
if releases is None:
udi = UbuntuDistroInfo()
releases = udi.supported()
In other words, same as this:
$ distro-info --supported
focal
jammy
lunar
mantic
However distro-info also includes a '--supported-esm' with additional releases considered "supported":
$ distro-info --supported-esm
trusty
xenial
bionic
focal
jammy
Launchpad also considers this broader set for it's "Supported Series" definition, as can be seen at https:/ /launchpad. net/ubuntu
The tests command won't show triggers for series unless there are packages for that series in the PPA, so it seems reasonable to adopt the broader definition of "supported" and assume if there's packages present in the PPA for bionic, trusty, or xenial they should have triggers displayed.
If someone has been using a given PPA for a long time, they may have obsolete stuff in it for those old releases that they don't care about. I don't know how important this use case is, and they can still use the '-r' flag to limit to a subset if they wish. Still, I should probably give this some additional thought. (Opinions would be welcome...)
In any case, the improved code would need just one line to fix:
$ python3
Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from distro_info import UbuntuDistroInfo
>>> udi = UbuntuDistroInfo()
>>> releases = udi.supported()
>>> releases
['focal', 'jammy', 'lunar', 'mantic']
>>> releases.extend(r for r in udi.supported_esm() if r not in releases)
>>> releases
['focal', 'jammy', 'lunar', 'mantic', 'trusty', 'xenial', 'bionic']