powervc-driver

image sync unescape the unneeded characters in configuration strategy property

Bug #1362886 reported by Terry Yao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
powervc-driver
Fix Committed
Undecided
Terry Yao

Bug Description

PowerVC Driver image service will sync the powervc image metadata properties into hosting openstack side, it will unescape the "<" and ">" chars in image's configuration_strategy property, the current code is using HTMLParser.unescape() that will unescape other chars that will bring up problem for the image's OVF that has some escaped char like "&quot;".

Terry Yao (yaohaif)
Changed in powervc-driver:
assignee: nobody → Terry Yao (yaohaif)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to powervc-driver (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117675

Changed in powervc-driver:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to powervc-driver (master)

Reviewed: https://review.openstack.org/117675
Committed: https://git.openstack.org/cgit/stackforge/powervc-driver/commit/?id=64233b7e1c15011bb597a19a2e6b97b6902f826e
Submitter: Jenkins
Branch: master

commit 64233b7e1c15011bb597a19a2e6b97b6902f826e
Author: Terry Yao <email address hidden>
Date: Fri Aug 29 09:56:20 2014 +0800

    Fix the issue to unescape unneed characters in image property

    Currently, powervc driver image sync service will sync the powervc image
    meta properties to hosting openstack side, it's using
    HTMLParser.unescape() to unescape the escape chars. It's over used, only
    "<", and ">" that corresponding escpae char is "&lt;" & "&gt;" is needed
    to be unescaped. Fix this only to unescape this two chars.

    Closes-Bug: #1362886
    Change-Id: I11db0cab46c8707a6c306f9967d7afc08fbad3ec

Changed in powervc-driver:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to powervc-driver (experimental)

Fix proposed to branch: experimental
Review: https://review.openstack.org/117739

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to powervc-driver (experimental)

Reviewed: https://review.openstack.org/117739
Committed: https://git.openstack.org/cgit/stackforge/powervc-driver/commit/?id=4d7fc1ad4403946a07ea7d362697478d627641c6
Submitter: Jenkins
Branch: experimental

commit 4d7fc1ad4403946a07ea7d362697478d627641c6
Author: Terry Yao <email address hidden>
Date: Fri Aug 29 09:56:20 2014 +0800

    Fix the issue to unescape unneed characters in image property

    Currently, powervc driver image sync service will sync the powervc image
    meta properties to hosting openstack side, it's using
    HTMLParser.unescape() to unescape the escape chars. It's over used, only
    "<", and ">" that corresponding escpae char is "&lt;" & "&gt;" is needed
    to be unescaped. Fix this only to unescape this two chars.

    Closes-Bug: #1362886
    Change-Id: I11db0cab46c8707a6c306f9967d7afc08fbad3ec

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.