List moderator cannot view the held messages, 403 status code returned

Bug #1443433 reported by Ankush Sharma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Postorius
Fix Committed
Undecided
Ankush Sharma

Bug Description

The list moderator cannot view the held messages by visiting the URL:
<base-url>/postorius/lists/<list-id>/held_messages

because the `list_moderator_required` decorator is not used at
http://bazaar.launchpad.net/~mailman-coders/postorius/trunk/view/head:/src/postorius/views/list.py#L477 .
This can be corrected by using the decorator `list_moderator_required` instead of `list_owner_required`.

Tags: postorius

Related branches

description: updated
description: updated
description: updated
tags: added: postorius
Changed in postorius:
assignee: nobody → Ankush Sharma (black-perl)
Revision history for this message
Bhavesh Goyal (bhavesh-goyal093) wrote :

The Bug has been discussed in a similar Bug Report.. This Bug is a part of the Bug #1431474 and a fix to the problem has already been linked. The same has also been linked here for an overview of the solution

Revision history for this message
Ankush Sharma (black-perl) wrote :

Hello Bhavesh,

In my opinion your fix is not correct because `MassSubscription` is not available to the list moderator. Also there are issues in list_nav.html where for rendering mass subscription option, the user is expected to be a 'list_moderator' . Since these are two different aspects. That's why I am attaching the relevant pull request for this bug.

Revision history for this message
Ankush Sharma (black-perl) wrote :

But most of your fix is correct, you can fix that part and update. I am not sending any pull !

Thanks.

Revision history for this message
Bhavesh Goyal (bhavesh-goyal093) wrote :

Hi Ankush,

Yes, missed the part that moderators didn't had access to mass subscriptions as I thought earlier. That line for denying access permissions was taken care of by Terri while merging the branch and the moderators now have access to held messages in contrast to it was earlier.

Revision history for this message
Ankush Sharma (black-perl) wrote :

Yep, you can update your pull now.

Terri (terriko)
Changed in postorius:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.