Postler

Difficulties with recipient parsing

Bug #804018 reported by Timo Kluck on 2011-06-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Postler	In Progress	Undecided	Unassigned

Bug Description

Postler does not handle recipients of the form

"Kluck, T.J." <tkluck@email>

very well, because of the comma in between of the quotes. In this case, it will think that

"Kluck

and

T.J" <tkluck@email>

are the two different contact the e-mail has been sent to.

I've published a branch with some modifications to give a better behaviour in this case.

Related branches

lp://staging/~tkluck/postler/contact-parsing

Ready for review for merging into lp://staging/postler

Cris Dywan: Pending requested 2011-07-08

Cris Dywan (kalikiana) on 2011-07-04

Changed in postler:
status:	New → Confirmed
assignee:	nobody → Christian Dywan (kalikiana)

Revision history for this message

Timo Kluck (tkluck) wrote on 2011-07-06:

There's some bugs in the branch I published that I'm trying to fix now. I've retracted my proposal to merge in the mean time. I'm sorry that I asked for a review too soon; I hope you haven't spent too much time on it yet.

I will send a new review request when I've fixed it.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2011-07-06:

difficulties-with-recipient-parsing.diff Edit (7.4 KiB, text/plain)

Hmm I actually just went over your changes because I hadn't seen your comment and updated them towards HEAD, and found them to be fairly broken. I'll attach it anyway since I have it done.

Some comments:

No cuddled brackets, please.

In the patch I added error messages to errors output.

I moved quoted_split() to Postler.Contact, I think it makes more sense there. The class is meant to deal with contacts as in addresses and names.

For testing I added a name to the mockup view you get with POSTLER_MOCKUP=1.

And eventually a proper name and email address are needed for crediting. Ideally as part of the patch, or send me in mail.

Changed in postler:
assignee:	Christian Dywan (kalikiana) → Timo Kluck (tkluck)
status:	Confirmed → In Progress

Revision history for this message

Timo Kluck (tkluck) wrote on 2011-07-06:

Thanks Christian for looking into my work, and sorry again for letting you work on the broken version. Your comments are useful though; I will update my branch accordingly. I will also look into the mockup you refer to; I didn't know it existed.

I will let you know as soon as this is ready for review.

Timo Kluck (tkluck) on 2012-02-04