Polly

New tweet textview is too small

Bug #974471 reported by Lars Karlitski
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Polly
Triaged
Medium
Unassigned

Bug Description

The new tweet textview is two lines high right now. Tweets which are longer than that (e.g. when they contain a non-shortened URL) lead to scrolling, which makes composing a tweet unecessarily complex and weird.

This could be solved by making the textview bigger when it contains more than two lines, a UI paradigm that is used in many other apps (for example in empathy's chat windows).

Lars Karlitski (larsu)
Changed in polly:
status: New → Opinion
Revision history for this message
Heimen Stoffels (vistaus) wrote :

I agree.

Revision history for this message
Conscious User (conscioususer) wrote :

That was my original intention, and TextView automatically does this if I don't do anything to its default values.

However, for whatever reason, once I use set_size_request on it (to increase its height since users complained that just one line was too claustrophobic), the auto-expansion stops working. Which is weird, since set_size_request is supposed to set a minimum size, not a maximum size.

The port to GTK3 is giving a new opportunity to see if I can work around this.

Changed in polly:
status: Opinion → Triaged
importance: Undecided → Medium
Revision history for this message
Lars Karlitski (larsu) wrote :

GtkScrolledWindow doesn't ever resize itself when its child window wants more space, it simply adds scrollbars. If you use a GtkTextView without a scrolled window parent, setting its minimum height to the equivalent of two lines will make it behave as expected.

Revision history for this message
Conscious User (conscioususer) wrote :

Actually, what I said above applies when I don't use a ScrolledWindow, the difference being that scrollbars do not appear and I have to use the arrow keys to scroll.

I added a ScrolledWindow *because* of the issue.

Revision history for this message
Lars Karlitski (larsu) wrote :

Strange. Maybe that's a gtk2-ism? It works fine in gtk3, just tested it with glade.

Revision history for this message
Conscious User (conscioususer) wrote :

I just tested it again just to be sure, it indeed happens without a scrolledwindow.

My hope is that it's indeed a gtk2-ism. :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.