We should keep the submission-resource job mandatory
Bug #1391774 reported by
Po-Hsu Lin
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| PlainBox (Toolkit) |
Fix Released
|
High
|
Maciej Kisielewski | ||
Bug Description
As we discussed in the Checkbox feedback meeting, we should keep this job mandatory or hide it from user-selection.
Sometimes user will de-select all test cases, but forgot to tick it back when doing some partial re-run, which will make the submission become a empty one.
Related branches
lp://staging/~kissiel/checkbox/fix-1391774-required-field-in-tp
- Checkbox Developers: Pending requested
-
Diff: 206 lines (+82/-7)4 files modifiedcheckbox-ng/checkbox_ng/commands/newcli.py (+5/-1)
plainbox/docs/manpages/plainbox-test-plan-units.rst (+9/-0)
plainbox/plainbox/impl/unit/test_testplan.py (+33/-2)
plainbox/plainbox/impl/unit/testplan.py (+35/-4)
lp://staging/~kissiel/checkbox/mandatory-jobs
- Zygmunt Krynicki (community): Approve
-
Diff: 74 lines (+57/-0)1 file modifiedplainbox/plainbox/impl/session/test_resume.py (+57/-0)
| tags: | added: ce-qa-concern |
| Changed in plainbox: | |
| status: | New → Confirmed |
| Changed in plainbox: | |
| importance: | Undecided → Medium |
| Changed in plainbox: | |
| importance: | Medium → High |
| Changed in plainbox: | |
| milestone: | none → 0.22 |
| Changed in plainbox: | |
| assignee: | nobody → Maciej Kisielewski (kissiel) |
| Changed in plainbox: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Maciej Kisielewski (kissiel) wrote | #1 |
| Changed in plainbox: | |
| milestone: | 0.22 → 0.23 |
| Changed in plainbox: | |
| status: | In Progress → Fix Committed |
| Changed in plainbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
My idea is to create a 'mandatory' flag for job definitions. This flag would make plainbox include this and all dependant jobs in every session. Jobs flagged as such could be rendered in front-ends using different style (e.g. greyed out) or hidden away completely.