disk/storage_device_sda fails on non-English systems

Did some investigation and found out the main reason seems to be in line #52 of script /usr/lib/plainbox-provider-checkbox/storage_test:
size=`parted -l -s |grep "Disk.*${disk}" |awk '{print $3}'`

On a Simplified Chinese Kylin system, perform the command "$sudo parted -l -s" and you will notice in the output that the string "Disk" is now replaced by the Chinese characters standing for "disk" (i.g. "磁盘").

The command size=`parted -l -s |grep "Disk.*${disk}" |awk '{print $3}'` therefore returns nothing, the script will terminate with "exit 1" and test case will fail.

Test case passed when I manually replaced "Disk" in line #52 of /usr/lib/plainbox-provider-checkbox/storage_test to "磁盘".

This script relies on grepping/regexp English text. As Kristin mentioned, line 52 is an example, but line 40 also uses English text:

    WARN=$(parted -s ${disk} print | grep "^Warning.*${disk}.*[Rr]ead-only" 2>&1)

According to Plainbox controller (checkbox/plainbox/plainbox/impl/ctrl.py), commands are run using LANG=C.UTF-8 (i.e. plain English language) unless explicitly mentioned in the job description (using the `preserve-locale` flag).

When running the following command:

    plainbox -C --trace plainbox.ctrl run -i .*disk/storage_device.*

we can see that the `storage_test` command is launched with pkexec as root using flag `LANG=C.UTF-8`.

However, the output still fails.

If we manually launch the command prefixed by the correct flags, the output works:

    LANG=C.UTF-8 LANGUAGE= sudo parted -l -s |grep "Disk.*sda" |awk '{print $3}'
    (this will return a value such as “500GB”)

The problem comes from the fact that in ctrl.py, we do not pass the “non-internationalized” LANGUAGE variable to pkexec (instead, we delete it from the dictionary used), so pkexec uses the one available in the system, which in the case of a Kylin system equals to “zh_CN:zh”.