Pinta

Undo of open Curve is not undone correctly

Bug #1888868 reported by grofaty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
In Progress
Medium
Unassigned

Bug Description

Latest Pinta PPA update 1.7+r1106-202007230322~ubuntu18.04.1:

1. From Tools select Rectangle.
2. Draw rectangle on canvas.
3. From toolbar Shake Type select Open Line/Curve Series.
4. Undo from toolbar and PROBLEM APPEARS. Undo does not do anything. I expect undo to return to fully closed rectangle to reappear because step 3 should be undone.
5. Click on Undo again properly undoes whole rectangle object.

Tags: line-tool
Revision history for this message
grofaty (grofaty) wrote :

Now retesting, problem is even wider. Every action selected from Shake Type and Undo does not work.

Revision history for this message
Cameron White (cameronwhite91) wrote :

Might be related to 1888872

Changed in pinta:
importance: Undecided → Medium
status: New → Confirmed
tags: added: line-tool
Revision history for this message
Bartosz (zetizero) wrote :

it's because SelectedShapeIndex is -1 while undo somehow. I'm trying to fix this.

Revision history for this message
Bartosz (zetizero) wrote :

Okay so there are 2 different problems with undo and redo. First SelectedShapeIndex is not correctly copied while undo/redo which makes undo/redo not working sometimes. Second problem is if you are using undo/redo by clicking on toolbar undo/redo works correctly but not show on screen immediately and you have to move your cursor to view to see that change on screen. (Funny thing if you are using ctrl+z, ctrl+shift+z istead of clicking in toolbar problem 2 does not appear).

I figured out how to fix first problem, you have to just copy SelectedShapeIndex manually in Swap function in ShapesModifyHistoryItem class.

But currently I don't know how to force view to refresh immediately.

Right now I don't have time so I will come back here in a few days and I will try to fix second problem also.

Bartosz (zetizero)
Changed in pinta:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.