openwith should have support for multiple globs
Bug #362081 reported by
Denilson Sá
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| PIDA |
New
|
Undecided
|
Unassigned | ||
Bug Description
PIDA 0.5.1 "openwith" service does not support multiple file globs for each item. It's handy because usually you have the same file handler for many file extensions.
I've currently hacked up a patch that adds this feature. It appears to work for me, but feel free to review and improve the patch as needed.
Another possible improvement is to add support for regular expressions. The current code I'm submitting with this patch already converts the list of globs to one regex, so it should be easy to add interface for adding regex directly.
For now, the code does not pre-compile the regex, and it would be better to do so. Feel free to add this improvement.
Revision history for this message
| Denilson Sá (denilsonsa) wrote | #1 |
Revision history for this message
| Denilson Sá (denilsonsa) wrote | #2 |
To post a comment you must log in.
Ah, I'm supposing the file storage of openwith preferences can store values containing newlines. If that's not the case, the file storage must be fixed.
Also, I'm not sure if the "save" button must be kept. It seems to me that the setting is auto-saved whenever it is changed, so I'm not sure if the save button is really useful.