wsrep_start_replication wsrep->connect rcode matching
Bug #1290526 reported by
Raghavendra D Prabhu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
MySQL patches by Codership |
Fix Committed
|
High
|
Unassigned | |||
5.5 |
Fix Committed
|
High
|
Unassigned | |||
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC | Status tracked in 5.6 | |||||
5.5 |
Fix Released
|
High
|
Alexey Kopytov | |||
5.6 |
Fix Released
|
High
|
Alexey Kopytov |
Bug Description
/tmp/bld/
if (-ESOCKTNOSUPPORT == rcode)
wsrep->connect() doesn't return anything else other than in wsrep_status_t, so that is always false.
tags: | added: lowhang |
To post a comment you must log in.
I think we can put rcode to errno inside wsrep->connect, since return type wsrep_status_t could only presents few status.
And change wsrep-mysql code as
=== modified file 'sql/wsrep_ mysqld. cc'
wsrep_ sst_donor,
bootstrap) )) "wsrep" ,("unrecognized cluster address: '%s', rcode: %d", address, rcode)); "unrecognized cluster address: '%s', rcode: %d", address, rcode); "wsrep" ,("wsrep- >connect( ) failed: %d", rcode)); "wsrep: :connect( ) failed: %d", rcode); "wsrep" ,("wsrep- >connect( %s) failed: %m", wsrep_cluster_ address) ); "wsrep- >connect( %s) failed: %m", wsrep_cluster_ address) ;
--- sql/wsrep_mysqld.cc 2014-05-04 07:12:59 +0000
+++ sql/wsrep_mysqld.cc 2014-05-13 08:53:08 +0000
@@ -810,19 +810,8 @@
{
- if (-ESOCKTNOSUPPORT == rcode)
- {
- DBUG_PRINT(
- wsrep_cluster_
- WSREP_ERROR(
- wsrep_cluster_
- }
- else
- {
- DBUG_PRINT(
- WSREP_ERROR(
- }
-
+ DBUG_PRINT(
+ WSREP_ERROR(
return false;
}
else