pt-online-schema-change add useless ORDER BY
Bug #898695 reported by
Laurent Bigonville
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
2.0 |
Won't Fix
|
Undecided
|
Unassigned | ||
2.1 |
Fix Released
|
Medium
|
Daniel Nichter |
Bug Description
Hi,
pt-online-
"SELECT MIN(foo), MAX(foo) FROM `db`.`table` ORDER BY `foo`"
and also
"SELECT MAX(LENGTH(foo)) FROM table ORDER BY `foo`"
Maybe other queries are also impacted
Related branches
lp://staging/~percona-toolkit-dev/percona-toolkit/pt-osc-2.1.1
- Baron Schwartz (community): Approve
- Daniel Nichter: Approve
- Brian Fraser: Pending requested
-
Diff: 9987 lines (+6370/-2594) (has conflicts)24 files modifiedbin/pt-online-schema-change (+4615/-1243)
bin/pt-table-checksum (+114/-37)
lib/CleanupTask.pm (+7/-2)
lib/MySQLStatusWaiter.pm (+34/-12)
lib/NibbleIterator.pm (+165/-49)
lib/OSCCaptureSync.pm (+0/-142)
lib/OobNibbleIterator.pm (+1/-1)
lib/SchemaIterator.pm (+12/-0)
t/lib/CleanupTask.t (+18/-1)
t/lib/MySQLStatusWaiter.t (+38/-4)
t/lib/NibbleIterator.t (+42/-4)
t/lib/OSCCaptureSync.t (+0/-131)
t/lib/OobNibbleIterator.t (+8/-3)
t/pt-online-schema-change/alter_active_table.t (+56/-46)
t/pt-online-schema-change/basics.t (+541/-218)
t/pt-online-schema-change/check_tables.t (+0/-126)
t/pt-online-schema-change/option_sanity.t (+12/-12)
t/pt-online-schema-change/samples/basic_no_fks.data (+500/-500)
t/pt-online-schema-change/samples/basic_no_fks.sql (+30/-0)
t/pt-online-schema-change/samples/basic_with_fks.sql (+56/-0)
t/pt-online-schema-change/samples/fk_tables_schema.sql (+0/-31)
t/pt-online-schema-change/samples/query_table.pl (+8/-5)
t/pt-online-schema-change/samples/small_table.sql (+0/-27)
t/pt-online-schema-change/sanity_checks.t (+113/-0)
tags: | added: pt-online-schema-change |
tags: | added: wrong-sql |
Changed in percona-toolkit: | |
status: | New → Confirmed |
Changed in percona-toolkit: | |
importance: | Undecided → Medium |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
milestone: | none → 2.1.1 |
To post a comment you must log in.
We need to update pt-online- schema- change to use NibbleIterator like pt-table-chekcsum 2.0. Currently, the tool uses the older, more complex table chunking code.