pt-stalk doesn't check pt-collect
Bug #884504 reported by
Fernando Ipar
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter | ||
| 1.0 |
Fix Released
|
Medium
|
Daniel Nichter | ||
Bug Description
This is a feature request:
pt-stalk looks for pt-collect in a hardcoded location (~/bin/pt-collect) if not configured.
However this is done at the time the trouble condition is triggered, meaning it may abort the chance for gathering data if pt-stalk is left running unattended without a properly configured or executable pt-collect.
I'm attaching a simple fix for this that would make pt-stalk abort upon start up if it finds $COLLECT isn't executable. t
Related branches
lp://staging/~daniel-nichter/percona-toolkit/fix-bug-884504
- Daniel Nichter: Approve
-
Diff: 51332 lines (+25301/-25383)109 files modified.bzrignore (+1/-0)
bin/pt-stalk (+5/-0)
docs/user/Makefile (+130/-0)
docs/user/authors.rst (+0/-9)
docs/user/bugs.rst (+0/-21)
docs/user/configuration_files.rst (+0/-115)
docs/user/copyright_license_and_warranty.rst (+0/-22)
docs/user/environment.rst (+0/-15)
docs/user/index.rst (+0/-31)
docs/user/make.bat (+170/-0)
docs/user/pt-archiver.rst (+0/-1556)
docs/user/pt-collect.rst (+0/-264)
docs/user/pt-config-diff.rst (+0/-518)
docs/user/pt-deadlock-logger.rst (+0/-760)
docs/user/pt-diskstats.rst (+0/-390)
docs/user/pt-duplicate-key-checker.rst (+0/-563)
docs/user/pt-fifo-split.rst (+0/-305)
docs/user/pt-find.rst (+0/-977)
docs/user/pt-fk-error-logger.rst (+0/-493)
docs/user/pt-heartbeat.rst (+0/-874)
docs/user/pt-index-usage.rst (+0/-840)
docs/user/pt-kill.rst (+0/-1053)
docs/user/pt-log-player.rst (+0/-795)
docs/user/pt-mext.rst (+0/-224)
docs/user/pt-mysql-summary.rst (+0/-233)
docs/user/pt-online-schema-change.rst (+0/-807)
docs/user/pt-pmp.rst (+0/-244)
docs/user/pt-query-advisor.rst (+0/-848)
docs/user/pt-query-digest.rst (+0/-2561)
docs/user/pt-show-grants.rst (+0/-534)
docs/user/pt-sift.rst (+0/-273)
docs/user/pt-slave-delay.rst (+0/-532)
docs/user/pt-slave-find.rst (+0/-543)
docs/user/pt-slave-restart.rst (+0/-755)
docs/user/pt-stalk.rst (+0/-367)
docs/user/pt-summary.rst (+0/-230)
docs/user/pt-table-checksum.rst (+0/-2036)
docs/user/pt-table-sync.rst (+0/-1627)
docs/user/pt-tcp-model.rst (+0/-531)
docs/user/pt-trend.rst (+0/-258)
docs/user/pt-upgrade.rst (+0/-824)
docs/user/pt-variable-advisor.rst (+0/-1100)
docs/user/pt-visual-explain.rst (+0/-963)
docs/user/release_notes.rst (+0/-41)
docs/user/source/authors.rst (+9/-0)
docs/user/source/bugs.rst (+22/-0)
docs/user/source/conf.py (+253/-0)
docs/user/source/configuration_files.rst (+115/-0)
docs/user/source/copyright_license_and_warranty.rst (+22/-0)
docs/user/source/environment.rst (+15/-0)
docs/user/source/glossary.rst (+31/-0)
docs/user/source/index.rst (+59/-0)
docs/user/source/installation.rst (+25/-0)
docs/user/source/percona-theme/layout.html (+473/-0)
docs/user/source/percona-theme/searchbox.html (+22/-0)
docs/user/source/percona-theme/static/default.css_t (+469/-0)
docs/user/source/percona-theme/static/jquery.min.js (+154/-0)
docs/user/source/percona-theme/static/percona.com.css (+1/-0)
docs/user/source/percona-theme/static/percona.com.js (+242/-0)
docs/user/source/percona-theme/static/sidebar.js (+151/-0)
docs/user/source/percona-theme/theme.conf (+32/-0)
docs/user/source/pt-archiver.rst (+1298/-0)
docs/user/source/pt-collect.rst (+125/-0)
docs/user/source/pt-config-diff.rst (+343/-0)
docs/user/source/pt-deadlock-logger.rst (+535/-0)
docs/user/source/pt-diskstats.rst (+230/-0)
docs/user/source/pt-duplicate-key-checker.rst (+381/-0)
docs/user/source/pt-fifo-split.rst (+171/-0)
docs/user/source/pt-find.rst (+773/-0)
docs/user/source/pt-fk-error-logger.rst (+377/-0)
docs/user/source/pt-heartbeat.rst (+705/-0)
docs/user/source/pt-index-usage.rst (+696/-0)
docs/user/source/pt-kill.rst (+887/-0)
docs/user/source/pt-log-player.rst (+697/-0)
docs/user/source/pt-mext.rst (+130/-0)
docs/user/source/pt-mysql-summary.rst (+140/-0)
docs/user/source/pt-online-schema-change.rst (+708/-0)
docs/user/source/pt-pmp.rst (+153/-0)
docs/user/source/pt-query-advisor.rst (+751/-0)
docs/user/source/pt-query-digest.rst (+2411/-0)
docs/user/source/pt-show-grants.rst (+439/-0)
docs/user/source/pt-sift.rst (+181/-0)
docs/user/source/pt-slave-delay.rst (+431/-0)
docs/user/source/pt-slave-find.rst (+448/-0)
docs/user/source/pt-slave-restart.rst (+614/-0)
docs/user/source/pt-stalk.rst (+270/-0)
docs/user/source/pt-summary.rst (+136/-0)
docs/user/source/pt-table-checksum.rst (+1849/-0)
docs/user/source/pt-table-sync.rst (+1539/-0)
docs/user/source/pt-tcp-model.rst (+439/-0)
docs/user/source/pt-trend.rst (+168/-0)
docs/user/source/pt-upgrade.rst (+731/-0)
docs/user/source/pt-variable-advisor.rst (+1008/-0)
docs/user/source/pt-visual-explain.rst (+847/-0)
docs/user/source/release-notes.rst (+198/-0)
docs/user/source/release_notes.rst (+41/-0)
docs/user/source/system_requirements.rst (+25/-0)
docs/user/source/tools.rst (+211/-0)
docs/user/source/version.rst (+7/-0)
docs/user/system_requirements.rst (+0/-25)
docs/user/tools.rst (+0/-211)
docs/user/version.rst (+0/-7)
lib/NibbleIterator.pm (+444/-0)
lib/RowChecksum.pm (+473/-0)
lib/SchemaIterator.pm (+1/-1)
lib/TableNibbler.pm (+5/-7)
t/lib/NibbleIterator.t (+457/-0)
t/lib/RowChecksum.t (+417/-0)
t/lib/samples/NibbleIterator/a-z.sql (+10/-0)
- Daniel Nichter: Approve
-
Diff: 15 lines (+5/-0)1 file modifiedbin/pt-stalk (+5/-0)
Revision history for this message
| Fernando Ipar (fipar) wrote | #1 |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #2 |
| summary: |
- pt-stalk should check for pt-collect at start time + pt-stalk doesn't check pt-collect |
| Changed in percona-toolkit: | |
| importance: | Undecided → Medium |
| milestone: | none → 2.0-beta2 |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| status: | New → Fix Committed |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #3 |
Revision history for this message
| Fernando Ipar (fipar) wrote | #4 |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
| Changed in percona-toolkit: | |
| status: | Fix Released → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #5 |
To post a comment you must log in.
Thanks Fernando. Since pt-stalk and pt-collect are so closely related, this is more than a feature request, it's a bug! After all, pt-stalk is almost useless if pt-collect isn't available, so pt-stalk should really check that it is before it's too late.