pt-stalk ominous open_tables function
Bug #1307377 reported by
MikeG
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Confirmed
|
Undecided
|
Unassigned | ||
Bug Description
Currently the open_tables function logs to the TS-opentables files what appears to be an error message, rather than a warning:
open_tables() {
local open_tables=
if [ -n "$open_tables" -a $open_tables -le 1000 ]; then
$CMD_MYSQL $EXT_ARGV -e 'SHOW OPEN TABLES' &
else
log "Too many open tables: $open_tables"
fi
}
This would be less confusing if it had a log entry that was more verbose, such as the following:
log "Logging disabled due to having over 1000 tables open. Number of tables currently open: $open_tables"
| tags: | added: pt-stalk |
Revision history for this message
| Nilnandan Joshi (nilnandan-joshi) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
Revision history for this message
| Sveta Smirnova (svetasmirnova) wrote | #2 |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #3 |
To post a comment you must log in.
Checked with pt-stalk 2.2.10.
open_tables() {
local open_tables=
if [ -n "$open_tables" -a $open_tables -le 1000 ]; then
$CMD_MYSQL $EXT_ARGV -e 'SHOW OPEN TABLES' &
else
log "Too many open tables: $open_tables"
fi
}