pt-heartbeat docs don't account for --utc
Bug #1137556 reported by
Roman Vynar
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Low
|
Daniel Nichter | ||
| 2.1 |
Fix Released
|
Low
|
Daniel Nichter | ||
| 2.2 |
Fix Released
|
Low
|
Daniel Nichter | ||
Bug Description
The doc is confusing, please see http://
it says "UTC_TIMESTAMP()":
INSERT INTO heartbeat (ts, server_id) VALUES (UTC_TIMESTAMP(), N);
...
INSERT INTO heartbeat (id, ts) VALUES (1, UTC_TIMESTAMP());
But actually it does:
729 Query INSERT INTO `percona`
or
731 Query INSERT INTO `percona`
depending --utc is used or not.
Please correct the doc as UTC is not always inserted.
Related branches
lp://staging/~percona-toolkit-dev/percona-toolkit/fix-pt-heartbeat-docs-bug-1137556
- Daniel Nichter: Approve
-
Diff: 42 lines (+16/-3)1 file modifiedbin/pt-heartbeat (+16/-3)
lp://staging/~percona-toolkit-dev/percona-toolkit/fix-pt-heartbeat-docs-bug-1137556-2.1
- Daniel Nichter: Approve
-
Diff: 42 lines (+16/-3)1 file modifiedbin/pt-heartbeat (+16/-3)
| Changed in percona-toolkit: | |
| milestone: | none → 2.2.1 |
| importance: | Undecided → Low |
| status: | New → Triaged |
| tags: | added: docs pt-heartbeat |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #1 |
| Changed in percona-toolkit: | |
| milestone: | 2.2.1 → 2.1.10 |
| summary: |
- minor doc update pt-heartbeat 2.1.9 + pt-heartbeat 2.1 docs don't account for --utc |
| Changed in percona-toolkit: | |
| assignee: | Daniel Nichter (daniel-nichter) → nobody |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| summary: |
- pt-heartbeat 2.1 docs don't account for --utc + pt-heartbeat docs don't account for --utc |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Actually, I'm going to retarget this to 2.1.10 because pt-heartbeat in 2.2 should alway use UTC, but that's another issue.