transaction logfile margin might be too large for >4GB logfile at XtraDB

Bug #715585 reported by Vadim Tkachenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Won't Fix
Undecided
Unassigned
5.5
Triaged
Medium
Unassigned

Bug Description

XtraDB support >4GB logfile.
Though for the normal ~4GB file around 25% margine is good (<1GB),
for the >4GB file the around 25% might be too large.
(e.g. if 16GB, margin is around 4GB?)

The margin should be adjusted for keep around 1GB for >4GB.

----(original)----
Facebook commit http://bazaar.launchpad.net/~mysqlatfacebook/mysqlatfacebook/5.1/revision/3625
contains implementation for innodb_sync_checkpoint_limit feature.
We need to look into porting it to Percona Server.

Changed in percona-server:
milestone: none → 5.5-21rc
assignee: nobody → Yasufumi Kinoshita (yasufumi-kinoshita)
Changed in percona-server:
milestone: 5.5-21rc → 5.5-20.1rc
Changed in percona-server:
status: New → Won't Fix
assignee: Yasufumi Kinoshita (yasufumi-kinoshita) → nobody
milestone: 5.5-20.1rc → none
Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

Why do you think the function is needed? for what?

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

I think the some part of the patch seems to increase danger possibility to overwrite transaction logs after the last checkpoint.
I don't accept it.

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote : Re: [Bug 715585] Re: port innodb_sync_checkpoint_limit from Facebook patch

Yasufumi,

There is option for one who wants to increase that.
By default there is no danger.

On Tue, Feb 22, 2011 at 10:51 PM, Yasufumi Kinoshita
<email address hidden> wrote:
> I think the some part of the patch seems to increase danger possibility to overwrite transaction logs after the last checkpoint.
> I don't accept it.
>
> ** Changed in: percona-server/5.5
>       Status: Confirmed => Invalid
>
> --
> You received this bug notification because you are a member of Percona
> developers, which is the registrant for Percona Server.
> https://bugs.launchpad.net/bugs/715585
>
> Title:
>  port innodb_sync_checkpoint_limit from Facebook patch
>
> Status in Percona Server with XtraDB:
>  Won't Fix
> Status in Percona Server 5.5 series:
>  Invalid
>
> Bug description:
>  Facebook commit http://bazaar.launchpad.net/~mysqlatfacebook/mysqlatfacebook/5.1/revision/3625
>  contains implementation for innodb_sync_checkpoint_limit feature.
>  We need to look into porting it to Percona Server.
>

--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-888-401-3403,  Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko

summary: - port innodb_sync_checkpoint_limit from Facebook patch
+ transaction logfile margin might be too large for >4GB logfile at XtraDB
Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

To save space for >4GB is acceptable. and changed the contents.

description: updated
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2605

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.