Percona Server moved to https://jira.percona.com/projects/PS

userstat.patch has several bugs (incorrectly ported from Google Tools for MySQL)

Bug #924872 reported by Oleg Tsarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.1
Won't Fix
Medium
Unassigned
5.5
Triaged
Medium
Unassigned
5.6
Triaged
Medium
Unassigned
5.7
Triaged
Medium
Unassigned

Bug Description

userstat.patch has several bugs:
 * WHERE and LIKE don't work with SHOW syntax (i.e. doesn't work (for example) SHOW CLIENT_STATISTICS LIKE 'client_name%')
 * Counter from *_STATISTICS don't update while connection live (updates from connection go to statistics just after connection close)
 * Incorrectly counted the kind of queries (Other/Select/etc)

See original description

Related branches

lp://staging/~tsarev/percona-server/5.1_fix_bug_924872
Laurynas Biveinis (community): Needs Fixing
Diff: 6527 lines (+4423/-975)
35 files modified
Percona-Server/mysql-test/include/show_stats.inc (+78/-0)
Percona-Server/mysql-test/include/show_table_index_stats.inc (+20/-0)
Percona-Server/mysql-test/r/access_denied.result (+330/-0)
Percona-Server/mysql-test/r/show_stats.result (+1735/-0)
Percona-Server/mysql-test/r/user_stats.result (+90/-0)
Percona-Server/mysql-test/r/userstat_bug602047.result (+2/-0)
Percona-Server/mysql-test/t/access_denied.test (+559/-0)
Percona-Server/mysql-test/t/show_stats.test (+484/-0)
Percona-Server/mysql-test/t/user_stats.test (+135/-0)
Percona-Server/mysql-test/t/userstat_bug602047.test (+2/-0)
Percona-Server/sql/handler.cc (+112/-64)
Percona-Server/sql/handler.h (+7/-4)
Percona-Server/sql/item.cc (+1/-0)
Percona-Server/sql/mysql_priv.h (+1/-1)
Percona-Server/sql/mysqld.cc (+0/-3)
Percona-Server/sql/set_var.cc (+3/-0)
Percona-Server/sql/sp_head.cc (+1/-0)
Percona-Server/sql/sql_acl.cc (+5/-0)
Percona-Server/sql/sql_base.cc (+1/-0)
Percona-Server/sql/sql_class.cc (+102/-76)
Percona-Server/sql/sql_class.h (+20/-35)
Percona-Server/sql/sql_connect.cc (+473/-524)
Percona-Server/sql/sql_db.cc (+1/-0)
Percona-Server/sql/sql_delete.cc (+2/-2)
Percona-Server/sql/sql_insert.cc (+2/-2)
Percona-Server/sql/sql_parse.cc (+30/-21)
Percona-Server/sql/sql_prepare.cc (+6/-6)
Percona-Server/sql/sql_show.cc (+134/-97)
Percona-Server/sql/sql_trigger.cc (+1/-0)
Percona-Server/sql/sql_update.cc (+2/-2)
Percona-Server/sql/sql_view.cc (+3/-0)
Percona-Server/sql/sql_yacc.yy (+5/-5)
Percona-Server/sql/structs.h (+49/-133)
Percona-Server/sql/table.cc (+1/-0)
Percona-Server/storage/myisam/ha_myisam.cc (+26/-0)
Oleg Tsarev (tsarev)
summary: - userstat.patch has many bugs (incorrectly ported from Google Tools for
- MySQL)
+ userstat.patch has several bugs (incorrectly ported from Google Tools
+ for MySQL)
description: updated
Marcos Albe (marcos-albe)
tags: added: i24564
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :
Download full text (3.8 KiB)

Tested on PS 5.5:

1)

SHOW CLIENT_STATISTICS like '%localhost%'\G
*************************** 1. row ***************************
                Client: localhost
     Total_connections: 2
Concurrent_connections: 0
        Connected_time: 24
             Busy_time: 0
              Cpu_time: 0
        Bytes_received: 243
            Bytes_sent: 0
  Binlog_bytes_written: 0
          Rows_fetched: 4
          Rows_updated: 0
       Table_rows_read: 0
       Select_commands: 4
       Update_commands: 0
        Other_commands: 1
   Commit_transactions: 0
 Rollback_transactions: 0
    Denied_connections: 0
      Lost_connections: 0
         Access_denied: 0
         Empty_queries: 0
 Total_ssl_connections: 0
1 row in set (0.00 sec)

mysql> SHOW CLIENT_STATISTICS like '%localhost%'\G
*************************** 1. row ***************************
                Client: localhost
     Total_connections: 2
Concurrent_connections: 0
        Connected_time: 122
             Busy_time: 0
              Cpu_time: 0
        Bytes_received: 289
            Bytes_sent: 0
  Binlog_bytes_written: 0
          Rows_fetched: 5
          Rows_updated: 0
       Table_rows_read: 0
       Select_commands: 5
       Update_commands: 0
        Other_commands: 1
   Commit_transactions: 0
 Rollback_transactions: 0
    Denied_connections: 0
      Lost_connections: 0
         Access_denied: 0
         Empty_queries: 0
 Total_ssl_connections: 0
1 row in set (0.00 sec)

mysql> SHOW CLIENT_STATISTICS like '%localhost%'\G
*************************** 1. row ***************************
                Client: localhost
     Total_connections: 2
Concurrent_connections: 0
        Connected_time: 124
             Busy_time: 0
              Cpu_time: 0
        Bytes_received: 335
            Bytes_sent: 0
  Binlog_bytes_written: 0
          Rows_fetched: 6
          Rows_updated: 0
       Table_rows_read: 0
       Select_commands: 6
       Update_commands: 0
        Other_commands: 1
   Commit_transactions: 0
 Rollback_transactions: 0
    Denied_connections: 0
      Lost_connections: 0
         Access_denied: 0
         Empty_queries: 0
 Total_ssl_connections: 0
1 row in set (0.00 sec)

2)

select * from table_statistics\G
*************************** 1. row ***************************
          TABLE_SCHEMA: mysql
            TABLE_NAME: user
             ROWS_READ: 7
          ROWS_CHANGED: 0
ROWS_CHANGED_X_INDEXES: 0
*************************** 2. row ***************************
          TABLE_SCHEMA: mysql
            TABLE_NAME: proxies_priv
             ROWS_READ: 2
          ROWS_CHANGED: 0
ROWS_CHANGED_X_INDEXES: 0
*************************** 3. row ***************************
          TABLE_SCHEMA: mysql
            TABLE_NAME: db
             ROWS_READ: 2
          ROWS_CHANGED: 0
ROWS_CHANGED_X_INDEXES: 0
3 rows in set (0.00 sec)

mysql> select * from mysql.user\G

..........
.........

mysql> select * from table_statistics\G
*************************** 1. row ***************************
          TABLE_SCHEMA: mysql
            TABLE_NAME: user
             ROWS_READ: 14
          ROWS_CHANGED: 0
ROWS_CHANGED_X_INDEXES: 0
*************************** 2. row *********...

Read more...

Laurynas Biveinis (laurynas-biveinis)
tags: added: userstat
Revision history for this message
Fernando Ipar (fipar) wrote :

I am not seeing the "Counter from *_STATISTICS don't update while connection live" part on 5.5.32-31.0.
I read a table from multiple threads and table_statistics.Rows_read reliably increases while the connections are open.

Is there a repeatable test case for this somewhere?

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Fernando -

If it's not repeatable it could have been fixed in the last year and a half, feel free to review the release notes or bugs tagged with "userstat".

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1235

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.