Debian build patches broken

Bug #1317864 reported by Patrick Domack
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.1
Invalid
Undecided
Unassigned
5.5
Triaged
High
Unassigned
5.6
Triaged
High
Unassigned
5.7
New
High
Unassigned

Bug Description

As in percona server 5.5 5.5.37-35.0, and some pervious versions.

dependency on dpatch is missing.
the dpatch include is missing from debian/rules
and 20_scripts__mysql_create_system_tables__no_test.dpatch doesn't apply anymore, and needs updating.

Tags: pkg
tags: added: pkg
Revision history for this message
Nilnandan Joshi (nilnandan-joshi) wrote :

Hi,

Can you please provide the output (copy/paste) which showing this problem for all those version you are talking about? it would be great help. Thanks.

Revision history for this message
Patrick Domack (patrickdk) wrote : Re: [Bug 1317864] Re: patches broken

Very simple, when you build, does the build log contain your patches?

applying patch 10_percona-server-prefix to ./ ... ok.
applying patch 20_scripts__mysql_create_system_tables__no_test to ./ ... ok.
applying patch 30_scripts__mysqld_safe.sh__signals to ./ ... ok.
applying patch 40_scripts__mysql_install_db.sh__no_test to ./ ... ok.
applying patch 50_mysql-test__db_test to ./ ... ok.

It doesn't, when you add dpatch, it will.

Also, in 5.5.37-35.1, with the fixed handlersocket; autoconf and
automake dependencies are missing, in order to build it.

https://launchpad.net/~patrickdk/+archive/general-lucid/+build/6079110

Quoting Nilnandan Joshi <email address hidden>:

> Hi,
>
> Can you please provide the output (copy/paste) which showing this
> problem for all those version you are talking about? it would be great
> help. Thanks.
>
> ** Changed in: percona-server/5.5
> Status: New => Incomplete
>
> ** Changed in: percona-server/5.6
> Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1317864
>
> Title:
> patches broken
>
> Status in Percona Server with XtraDB:
> Incomplete
> Status in Percona Server 5.1 series:
> Invalid
> Status in Percona Server 5.5 series:
> Incomplete
> Status in Percona Server 5.6 series:
> Incomplete
>
> Bug description:
> As in percona server 5.5 5.5.37-35.0, and some pervious versions.
>
> dependency on dpatch is missing.
> the dpatch include is missing from debian/rules
> and 20_scripts__mysql_create_system_tables__no_test.dpatch doesn't
> apply anymore, and needs updating.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/percona-server/+bug/1317864/+subscriptions

Revision history for this message
Tomislav Plavcic (tplavcic) wrote : Re: patches broken

I have verified this - this is missing probably after big packaging changes in versions 5.5.36-34.0 and 5.6.16-64.1
After adding dependency and include line patches work.
Just need to see what's with the 20_scripts__mysql_create_system_tables__no_test.dpatch and what needs to be changed regarding that one.
Automake and autoconf part for 5.5 is also correct since for 5.5 handlersocket wasn't ported to cmake.

Thank you Patrick!

summary: - patches broken
+ Debian build patches broken
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

I don't think any patches in patches/ are applied at the moment. I think this
may be because after layout/library fixes, some/all the fixes done by patches
were merged into tree.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-786

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.