free-format signed tags treated as versions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
PBR |
Fix Released
|
Critical
|
Robert Collins |
Bug Description
pbr (incorrectly) accepts free-form tags as versions and puts those in the pip metadata. until recently this was not very visible, but since pbr started validating the versions it created, bad tags result in bad versions.
The symptom will look something like:
Traceback (most recent call last):
File "/usr/local/
sys.
File "/opt/stack/
config.
File "/opt/stack/
version=
File "/usr/local/
return self.semantic_
File "/usr/local/
self._semantic = self._get_
File "/usr/local/
return SemanticVersion
File "/usr/local/
major = int(components[0])
ValueError: invalid literal for int() with base 10: 'cee-trunkport'
n-api failed to start
(In this case the nova repository has a most recent signed tag 'cee/trunkport-
WORKAROUNDS
===========
In the source tree with the tag either:
- convert the signed tag to an unsigned tag
- add a newer tag that is a valid version
- delete the signed tag
Then sdist and install the resulting package
PROPOSED FIX
============
Ignore such tags and walk history back to an actual usable tag
description: | updated |
Changed in pbr: | |
milestone: | none → next-juno |
Changed in pbr: | |
milestone: | next-juno → juno-rc1 |
Changed in pbr: | |
milestone: | juno-rc1 → next-juno |
Changed in pbr: | |
milestone: | next-juno → juno-rc1 |
Changed in pbr: | |
milestone: | next-juno → next-kilo |
Changed in pbr: | |
status: | Fix Committed → Fix Released |
I believe https:/ /review. openstack. org/114093 fixes this... can you confirm?