Cannot copy-paste a link
Bug #1169255 reported by
Samu Nuutamo
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Terminal |
Fix Committed
|
Low
|
Unassigned | ||
Bug Description
When I try to select a URL from the terminal the click is always registered as if I wanted to open the link. What I think should be changed is the way the click event is handled. When link is clicked it should be opened only 1) on mouseup event and 2) if the cursor has not moved from mousedown position. If the cursor is moved between mousedown and mouseup the text should be selected instead.
Related branches
lp://staging/~c.groner/pantheon-terminal/fix-1169255
- Adam Bieńkowski (community): Approve (code / testing)
-
Diff: 74 lines (+29/-24)2 files modifiedsrc/PantheonTerminalWindow.vala (+1/-1)
src/TerminalWidget.vala (+28/-23)
| Changed in pantheon-terminal: | |
| assignee: | nobody → elementary UX Team (elementary-design) |
| Changed in pantheon-terminal: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in pantheon-terminal: | |
| assignee: | elementary UX Team (elementary-design) → nobody |
| Changed in pantheon-terminal: | |
| assignee: | nobody → Gerald Javier Padilla (gpadillaq) |
| Changed in pantheon-terminal: | |
| assignee: | Gerald Javier Padilla (gpadillaq) → nobody |
| assignee: | nobody → Gerald Javier Padilla (gpadillaq) |
| Changed in pantheon-terminal: | |
| assignee: | Gerald Javier Padilla (gpadillaq) → nobody |
| Changed in pantheon-terminal: | |
| status: | Confirmed → Fix Committed |
| Changed in pantheon-terminal: | |
| milestone: | none → juno-beta1 |
Revision history for this message
| Samu Nuutamo (carbon) wrote | #1 |
Revision history for this message
| Carl Groner (c.groner) wrote | #2 |
To post a comment you must log in.
Hello and thanks for the fix. There is one issue though: if the link is clicked and the cursor is moved after the button has been released, text will be selected while the browser opens. There is around 1 sec window after clicking when the text is still selected. This causes text to be highlighted by accident almost every time I click a link :(.
I'm wondering if the call to open the url blocks while the binary is loading and this causes the text to be erroneously selected. On the other hand it didn't matter if the browser was already open - the issue was still there.
My terminal is in version 0.4.1-0~