Files

Icons should be Grid

Bug #1021550 reported by Danielle Foré
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Files
Fix Released
Low
Cody Garver
Files luna-beta1

Bug Description

All views use icons. The currently named "icon" view should instead be called "Grid"

Related branches

lp://staging/~codygarver/pantheon-files/fix-1021550
Danielle Foré: Approve
Diff: 445 lines (+6/-400)
5 files modified
icons/CMakeLists.txt (+1/-1)
icons/view-list-compact-symbolic.svg (+0/-151)
icons/view-list-details-symbolic.svg (+0/-84)
icons/view-list-icons-symbolic.svg (+0/-159)
src/View/Chrome/ViewSwicher.vala (+5/-5)
Revision history for this message
Cody Garver (codygarver) wrote :

I guess you mean "grid" and not capitalized "Grid". I will submit a branch to Marlin.

Changed in pantheon-files:
status: New → In Progress
milestone: none → luna-beta1
Revision history for this message
Danielle Foré (danrabbit) wrote :

Cody, I'm pretty sure we typically use Title Case in tooltips, but I could be wrong.

Revision history for this message
Cody Garver (codygarver) wrote :

Congratulations, you just won a new project-wide bug.

Noise has Title Case tooltips, others do not.

Chromium does not use Title Case. Does that change your stance?

Revision history for this message
Danielle Foré (danrabbit) wrote :

Okay, it looks like most apps use Sentence case. Chromium is not really a good reference point in any case because it's not a native app.

The next question however is do we just use the view name alone "Grid" "List" etc like Slingshot or do we use a sentence "View as grid" "View as list" like Files.

Danielle Foré (danrabbit)
Changed in pantheon-files:
assignee: nobody → Cody Garver (codygarver)
Danielle Foré (danrabbit)
Changed in pantheon-files:
status: In Progress → Fix Committed
Sergey "Shnatsel" Davidoff (shnatsel)
Changed in pantheon-files:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.