Implement Screen::GetShellMode()
Bug #1610929 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Incomplete
|
Undecided
|
Unassigned | ||
Oxide |
Fix Released
|
High
|
Santosh | ||
mir (Ubuntu) |
Incomplete
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
This is currently just a stub that returns NonWindowed on mobile devices and Windowed everywhere else. It needs to be more intelligent than that (eg, Windowed on a tablet device) and needs to be dynamic, but I don't think there's a way for us to do that yet.
Basically, we need to know whether the shell is in windowed or staged mode. The display's form factor isn't particularly relevant.
This is needed to complete bug 1545088 and others.
Related branches
~santoshbit2007/oxide:GetShellMode_Implementation
Merged
into
oxide:master
- Chris Coulson: Approve
-
Diff: 404 lines (+176/-9)13 files modifiedbuild/cmake/ChromiumBuildShim.cmake (+13/-0)
build/config/Qt5/BUILD.gn (+8/-0)
build/config/Qt5/moc.gni (+12/-3)
build/config/Qt5/moc.py (+6/-1)
build/config/build_flags.gni (+2/-0)
build/config/linux/qt/BUILD.gn (+7/-0)
qt/core/BUILD.gn (+14/-0)
qt/core/browser/qt_screen.cc (+90/-0)
qt/core/browser/qt_screen.h (+18/-0)
shared/browser/oxide_content_browser_client.cc (+1/-1)
shared/browser/screen.h (+1/-1)
shared/browser/screen_observer.h (+1/-0)
shared/browser/screen_unittest.cc (+3/-3)
Changed in oxide: | |
importance: | Undecided → High |
status: | New → Triaged |
description: | updated |
Changed in oxide: | |
status: | Triaged → Fix Released |
milestone: | none → branch-1.20 |
assignee: | nobody → Santosh (santoshbit2007) |
To post a comment you must log in.
Can mir and / or unity8 give us that information?