beforeunload handlers can't specify message text in Chromium 51

Bug #1556658 reported by Chris Coulson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
High
Chris Coulson
webbrowser-app (Ubuntu)
New
Undecided
Unassigned

Bug Description

Chromium has dropped the ability for beforeunload handlers to set the dialog message text. Instead, Chromium will display a stock message, making it behave the same as Firefox. This will affect Oxide too - beforeunload dialog components will be created with an empty message string.

I assume webbrowser-app already handles an empty message string by displaying its own text, but given that this API exists in Oxide, I wonder whether we should specify a stock message in Oxide and expose it via the existing API.

See:
https://chromium.googlesource.com/chromium/src.git/+/141dbc132f8aa2588fad4cf50fbfd7a319234b61
https://bugs.chromium.org/p/chromium/issues/detail?id=587940

Changed in oxide:
milestone: none → branch-1.15
Revision history for this message
Olivier Tilloy (osomon) wrote :

webbrowser-app currently doesn’t handle the empty mesage case. We could make it handle it, of course, but I think your proposal of exposing the stock message to the existing Oxide API makes sense, as it would mean no API/behaviour changes.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Ok, I'll add a string to Oxide so that we don't break existing apps. I'll add a deprecation warning for this as well.

I'm just about to merge Chromium 51.0.2679.0 in to trunk. There are a couple of test failures until this is resolved.

Changed in oxide:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Chris Coulson (chrisccoulson)
Changed in oxide:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.