Oxide

oxide::qt::LocationProvider should be paused when the application becomes inactive

Bug #1402994 reported by Olivier Tilloy on 2014-12-16

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	High	Unassigned	Canonical System Image ww11-ota
Oxide	Invalid	High	Alexandre Abreu
qtubuntu-sensors (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

If a WebView is used to browse to a page that requests continuous position updates, the LocationProvider should be paused when the application goes in the background, and resumed when it gets back in the foreground.

This could be implemented by making oxide::qt::LocationProvider a BrowserPlatformIntegrationObserver.

Tags:

Related branches

lp://staging/~abreu-alexandre/oxide/location-provider-app-lifecycle

Rejected for merging into lp://staging/oxide/1.4

Alexandre Abreu (community): Disapprove on 2015-02-26

Chris Coulson: Needs Fixing on 2015-02-26

lp://staging/~ricmm/qtubuntu-sensors/browser-location-rtm (Merged)

lp://staging/~ricmm/qtubuntu-sensors/browser-location-vivid

Merged into lp://staging/qtubuntu-sensors at revision 84

Ricardo Salveti (community): Approve on 2015-02-27

PS Jenkins bot: Approve (continuous-integration) on 2015-02-26

lp://staging/ubuntu/vivid-proposed/qtubuntu-sensors

Olivier Tilloy (osomon) on 2014-12-16

Changed in oxide:
assignee:	nobody → Olivier Tilloy (osomon)

Olivier Tilloy (osomon) on 2014-12-16

Changed in oxide:
status:	New → In Progress

Revision history for this message

Olivier Tilloy (osomon) wrote on 2014-12-16:

It turns out LocationProvider can’t safely be made a BrowserPlatformIntegrationObserver, as it’s owned by the geolocation thread (we’d need to guarantee it stays alive during the state change, which implies it has to be reference counted, which means the whole ownership model in chromium has to be changed).

Changed in oxide:
status:	In Progress → Confirmed

David Barth (dbarth) on 2015-02-25

Changed in oxide:
assignee:	Olivier Tilloy (osomon) → Alexandre Abreu (abreu-alexandre)
importance:	Undecided → High

Pat McGowan (pat-mcgowan) on 2015-02-26

Changed in canonical-devices-system-image:
status:	New → In Progress
importance:	Undecided → High
milestone:	none → ww13-ota

Pat McGowan (pat-mcgowan) on 2015-02-26

tags:

added: battery

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2015-02-26:

The fix has been moved to qtsensors that automativally handles application state updates and starts/stops the geolocation source automatically,

Changed in oxide:
status:	Confirmed → Invalid

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-02-27:

This bug was fixed in the package qtubuntu-sensors - 0.6+15.04.20150226-0ubuntu1

---------------
qtubuntu-sensors (0.6+15.04.20150226-0ubuntu1) vivid; urgency=medium

[ CI Train Bot ]
* New rebuild forced.

  [ Ricardo Mendoza ]
  * Connect to application state signals directly and explicitly by
    registering the meta type in case we dont live on the UI thread. Fix
    #1402994. (LP: #1402994)
-- CI Train Bot <email address hidden> Thu, 26 Feb 2015 19:38:31 +0000