Oxide

Delegate unhandled URL schemes to the system

Bug #1384460 reported by Chris Coulson
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww51-2014
Oxide
Fix Released
High
Olivier Tilloy
Oxide branch-1.4
1.3
Fix Released
High
Olivier Tilloy
Oxide 1.3.2
dialer-app
Fix Released
High
Gustavo Pichorim Boiko
dialer-app (Ubuntu)
Fix Released
High
Unassigned
dialer-app (Ubuntu RTM)
Fix Released
High
Unassigned
url-dispatcher (Ubuntu)
Fix Released
High
Ted Gould
url-dispatcher (Ubuntu RTM)
Fix Released
High
Ted Gould
webbrowser-app (Ubuntu)
Fix Released
Undecided
Unassigned
webbrowser-app (Ubuntu RTM)
Fix Released
Undecided
Olivier Tilloy

Bug Description

We currently ignore any URL's with a scheme that is unrecognised. We should be delegating these to the system so that it can try to find a handler for it

Tags: ota-1 rtm14

Related branches

lp://staging/~osomon/oxide/delegate-unhandled-url-schemes
Chris Coulson: Approve
Diff: 532 lines (+308/-7)
18 files modified
qt/core/browser/oxide_qt_platform_integration.cc (+36/-0)
qt/core/browser/oxide_qt_platform_integration.h (+36/-0)
qt/core/core.gyp (+2/-0)
qt/core/glue/oxide_qt_init.cc (+4/-1)
qt/tests/qmltests/CMakeLists.txt (+1/-1)
qt/tests/qmltests/api/tst_WebFrame_url.qml (+8/-0)
qt/tests/qmltests/api/tst_WebView_url.qml (+8/-0)
qt/tests/qmltests/core/tst_CustomURLSchemes.qml (+8/-0)
qt/tests/qmltests/core/tst_UnhandledURLSchemes.qml (+55/-0)
qt/tests/qmltests/core/tst_UnhandledURLSchemes1.html (+10/-0)
qt/tests/qmltests/core/tst_UnhandledURLSchemes2.html (+9/-0)
qt/tests/qmltests/oxide_qml_testing_plugin.cc (+20/-0)
shared/browser/oxide_browser_process_main.cc (+9/-3)
shared/browser/oxide_browser_process_main.h (+3/-1)
shared/browser/oxide_platform_integration.cc (+51/-0)
shared/browser/oxide_platform_integration.h (+44/-0)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+2/-1)
shared/shared.gyp (+2/-0)
lp://staging/~osomon/dialer-app/handle-slashless-urls
Gustavo Pichorim Boiko (community): Approve
Diff: 29 lines (+7/-5)
1 file modified
src/dialerapplication.cpp (+7/-5)
Gustavo Pichorim Boiko (community): Approve
Diff: 29 lines (+7/-5)
1 file modified
src/dialerapplication.cpp (+7/-5)
lp://staging/~ted/url-dispatcher/more-sophisticated-urls
PS Jenkins bot (community): Approve (continuous-integration)
Charles Kerr (community): Approve
Diff: 76 lines (+43/-1)
2 files modified
service/dispatcher.c (+2/-1)
tests/dispatcher-test.cc (+41/-0)
Charles Kerr (community): Approve
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 76 lines (+43/-1)
2 files modified
service/dispatcher.c (+2/-1)
tests/dispatcher-test.cc (+41/-0)
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 76 lines (+43/-1)
2 files modified
service/dispatcher.c (+2/-1)
tests/dispatcher-test.cc (+41/-0)
lp://staging/oxide/1.3
lp://staging/ubuntu/vivid-proposed/webbrowser-app
lp://staging/~osomon/webbrowser-app/rtm-14.09-no-htpp
Ubuntu Phablet Team: Pending requested
Diff: 23 lines (+2/-2)
2 files modified
tests/autopilot/webbrowser_app/tests/test_errorsheet.py (+1/-1)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+1/-1)
lp://staging/~osomon/webbrowser-app/no-htpp
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 23 lines (+2/-2)
2 files modified
tests/autopilot/webbrowser_app/tests/test_errorsheet.py (+1/-1)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+1/-1)
lp://staging/~oxide-developers/oxide/packaging.utopic
lp://staging/~oxide-developers/oxide/packaging.trusty
Chris Coulson (chrisccoulson)
Changed in oxide:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Olivier Tilloy (osomon) wrote :

An example of such URLs is telephone links (typically exposed on mobile versions of websites), e.g. "tel:+1234567890".

It seems url-dispatcher is expecting links in the form "tel:///+1234567890" though, it currently refuses to handle the slash-less form.

Olivier Tilloy (osomon)
Changed in oxide:
assignee: nobody → Olivier Tilloy (osomon)
status: Triaged → In Progress
Chris Coulson (chrisccoulson)
Changed in oxide:
milestone: none → branch-1.4
Revision history for this message
Chris Wayne (cwayne) wrote :

This has been identified as a customer blocking bug, please raise priority to Critical and mark rtm14

Pat McGowan (pat-mcgowan)
tags: added: rtm14 touch-2014-10-30
Olivier Tilloy (osomon)
Changed in oxide:
importance: Medium → High
Olivier Tilloy (osomon)
Changed in oxide:
milestone: branch-1.4 → 1.3.2
Chris Coulson (chrisccoulson)
Changed in oxide:
milestone: 1.3.2 → branch-1.4
Olivier Tilloy (osomon)
Changed in oxide:
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+15.04.20141104.1-0ubuntu1

---------------
webbrowser-app (0.23+15.04.20141104.1-0ubuntu1) vivid; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Riccardo Padovani ]
  * Added new upstream components to fit with design requests: multiple
    selection in History, standard swipe-to-delete. (LP: #1351167)

  [ Olivier Tilloy ]
  * Do not use a custom scheme to trigger the error page, this won’t
    work any longer as soon as oxide learns how to delegate unhandled
    schemes (see https://launchpad.net/bugs/1384460). (LP: #1384460)
  * Ensure that the 'dataLocation' context property is updated when the
    application name changes. (LP: #1387754)
  * Really honour the --fullscreen command-line switch. (LP: #1379766)
 -- Ubuntu daily release <email address hidden> Tue, 04 Nov 2014 15:22:49 +0000

Changed in webbrowser-app (Ubuntu):
status: New → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu RTM):
status: New → Confirmed
Pat McGowan (pat-mcgowan)
tags: added: ota-1
removed: touch-2014-10-30
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

marking ota, this will release mid nov

Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu RTM):
status: Confirmed → In Progress
assignee: nobody → Olivier Tilloy (osomon)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+15.04.20141118~rtm-0ubuntu1

---------------
webbrowser-app (0.23+15.04.20141118~rtm-0ubuntu1) 14.09; urgency=low

  [ Olivier Tilloy ]
  * Do not use a custom scheme to trigger the error page, this won’t
    work any longer as soon as oxide learns how to delegate unhandled
    schemes (see https://launchpad.net/bugs/1384460). (LP: #1384460)
 -- Ubuntu daily release <email address hidden> Tue, 18 Nov 2014 20:22:13 +0000

Changed in webbrowser-app (Ubuntu RTM):
status: In Progress → Fix Released
Revision history for this message
Olivier Tilloy (osomon) wrote :

I added a canonical-devices-system-image task to consider merging the dialer-app branch in RTM (all the other pieces already made it to RTM).

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

approve the final MR to land as we thought the bug was closed

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww51-2014
status: New → Confirmed
Bill Filler (bfiller)
Changed in dialer-app:
status: New → In Progress
Changed in dialer-app (Ubuntu):
status: New → Fix Released
Changed in dialer-app (Ubuntu RTM):
status: New → In Progress
Changed in dialer-app:
importance: Undecided → High
Changed in dialer-app (Ubuntu):
importance: Undecided → High
Changed in dialer-app (Ubuntu RTM):
importance: Undecided → High
Changed in dialer-app:
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Bill Filler (bfiller)
Changed in url-dispatcher (Ubuntu):
importance: Undecided → High
Changed in url-dispatcher (Ubuntu RTM):
importance: Undecided → High
Thomas Strehl (strehl-t)
Changed in url-dispatcher (Ubuntu RTM):
assignee: nobody → Ted Gould (ted)
Changed in url-dispatcher (Ubuntu):
assignee: nobody → Ted Gould (ted)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
status: Fix Released → Confirmed
Bill Filler (bfiller)
Changed in url-dispatcher (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package url-dispatcher - 0.1+15.04.20141208~rtm-0ubuntu1

---------------
url-dispatcher (0.1+15.04.20141208~rtm-0ubuntu1) 14.09; urgency=low

  [ Ted Gould ]
  * Making generic regular expression more robust (LP: #1384460,
    #1351222)
 -- Ubuntu daily release <email address hidden> Mon, 08 Dec 2014 17:44:20 +0000

Changed in url-dispatcher (Ubuntu RTM):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dialer-app - 0.1+15.04.20141208.1~rtm-0ubuntu1

---------------
dialer-app (0.1+15.04.20141208.1~rtm-0ubuntu1) 14.09; urgency=low

  [ Gustavo Pichorim Boiko ]
  * Hide the SIM selector when in emergency mode. (LP: #1379386)
  * Only set the CallManager.callIndicatorVisible flag when
    CallManager.hasCalls. (LP: #1390098)
  * Enable page to receive focus.
  * Add empty state in the history page. (LP: #1367325)

  [ Olivier Tilloy ]
  * Also handle URLs of the form "tel:+1234567890", i.e. without slashes
    (those are common on web pages). (LP: #1384460, #1351222)
 -- Ubuntu daily release <email address hidden> Mon, 08 Dec 2014 17:41:09 +0000

Changed in dialer-app (Ubuntu RTM):
status: In Progress → Fix Released
Olivier Tilloy (osomon)
Changed in dialer-app:
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.