Implement a touch editing UI
Bug #1376268 reported by
Chris Coulson
This bug affects 28 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
David Barth | ||
| Oxide |
Fix Released
|
High
|
Olivier Tilloy | ||
| 1.12 |
Fix Released
|
High
|
Olivier Tilloy | ||
| Ubuntu UX |
Fix Released
|
High
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
For copy / paste support on the device, we need to implement a touch editing UI in Oxide (the touch editing UI is basically the handles that you can drag around to select blocks of text)
Related branches
lp://staging/~osomon/oxide/touch-selection-api
- Chris Coulson: Approve
- Olivier Tilloy (community): Abstain
-
Diff: 2496 lines (+1435/-54)37 files modifiedqt/core/browser/oxide_qt_browser_platform_integration.cc (+8/-3)
qt/core/browser/oxide_qt_browser_platform_integration.h (+1/-0)
qt/core/browser/oxide_qt_touch_handle_drawable.cc (+105/-0)
qt/core/browser/oxide_qt_touch_handle_drawable.h (+56/-0)
qt/core/browser/oxide_qt_web_context_menu.cc (+1/-0)
qt/core/browser/oxide_qt_web_view.cc (+58/-4)
qt/core/browser/oxide_qt_web_view.h (+13/-7)
qt/core/core.gyp (+4/-1)
qt/core/glue/oxide_qt_touch_handle_drawable_proxy.h (+56/-0)
qt/core/glue/oxide_qt_web_context_menu_proxy_client.h (+0/-11)
qt/core/glue/oxide_qt_web_view_proxy.h (+18/-4)
qt/core/glue/oxide_qt_web_view_proxy_client.h (+8/-1)
qt/qmlplugin/oxide.qmltypes (+28/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+3/-0)
qt/quick/CMakeLists.txt (+3/-1)
qt/quick/api/oxideqquicktouchselectioncontroller.cc (+92/-0)
qt/quick/api/oxideqquicktouchselectioncontroller_p.h (+74/-0)
qt/quick/api/oxideqquickwebview.cc (+45/-1)
qt/quick/api/oxideqquickwebview_p.h (+10/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+7/-1)
qt/quick/oxide_qquick_touch_handle_drawable.cc (+286/-0)
qt/quick/oxide_qquick_touch_handle_drawable.h (+70/-0)
qt/quick/oxide_qquick_web_context_menu.cc (+1/-0)
qt/tests/qmltests/api/tst_WebView_editingCapabilities.html (+6/-0)
qt/tests/qmltests/api/tst_WebView_editingCapabilities.qml (+132/-0)
shared/browser/oxide_browser_platform_integration.cc (+6/-0)
shared/browser/oxide_browser_platform_integration.h (+2/-0)
shared/browser/oxide_browser_platform_integration_observer.h (+3/-1)
shared/browser/oxide_render_widget_host_view.cc (+153/-2)
shared/browser/oxide_render_widget_host_view.h (+27/-1)
shared/browser/oxide_render_widget_host_view_container.h (+12/-1)
shared/browser/oxide_web_view.cc (+100/-4)
shared/browser/oxide_web_view.h (+18/-5)
shared/browser/oxide_web_view_client.cc (+10/-1)
shared/browser/oxide_web_view_client.h (+16/-1)
shared/renderer/oxide_content_renderer_client.cc (+1/-3)
shared/shared.gyp (+2/-1)
lp://staging/~osomon/webbrowser-app/touch-selection-controller
- Alexandre Abreu (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 348 lines (+222/-12)7 files modifieddebian/control (+2/-2)
src/Ubuntu/Web/CMakeLists.txt (+4/-4)
src/Ubuntu/Web/UbuntuWebView02.qml (+101/-1)
tests/autopilot/webapp_container/tests/test_context_menu.py (+4/-4)
tests/autopilot/webbrowser_app/tests/http_server.py (+6/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+2/-1)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+103/-0)
| Changed in oxide: | |
| milestone: | none → branch-1.4 |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in oxide: | |
| milestone: | branch-1.4 → branch-1.5 |
| Changed in oxide: | |
| milestone: | branch-1.5 → branch-1.6 |
| assignee: | nobody → Chris Coulson (chrisccoulson) |
| Changed in oxide: | |
| milestone: | branch-1.6 → branch-1.8 |
| Changed in oxide: | |
| milestone: | branch-1.8 → branch-1.9 |
| tags: | added: selection |
| Changed in oxide: | |
| status: | Triaged → Confirmed |
| Changed in oxide: | |
| status: | Confirmed → Triaged |
| Changed in oxide: | |
| milestone: | branch-1.9 → branch-1.11 |
| Changed in oxide: | |
| assignee: | Chris Coulson (chrisccoulson) → Olivier Tilloy (osomon) |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #1 |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Pat McGowan (pat-mcgowan) |
| importance: | Undecided → High |
| milestone: | none → ww46-2015 |
| status: | New → Confirmed |
| Changed in oxide: | |
| milestone: | branch-1.11 → branch-1.12 |
| Changed in oxide: | |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| milestone: | ww46-2015 → ww02-2016 |
| assignee: | Pat McGowan (pat-mcgowan) → David Barth (dbarth) |
| milestone: | ww02-2016 → none |
| milestone: | none → ww02-2016 |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → High |
| status: | New → Triaged |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Changed in ubuntu-ux: | |
| assignee: | nobody → James Mulholland (jamesjosephmulholland) |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in oxide: | |
| milestone: | branch-1.12 → branch-1.13 |
| Changed in oxide: | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| milestone: | ww02-2016 → ww08-2016 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
target ota 8