os-cloud-config

Incorrect usage of python-novaclient

Bug #1493576 reported by Andrey Kurilin on 2015-09-08

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Cinder	Fix Released	Medium	Ivan Kolodyazhny	Cinder 7.0.0 "liberty"
Mistral	Fix Released	High	Zhenguo Niu	Mistral 1.0.0 "liberty"
OpenStack DBaaS (Trove)	Fix Released	Undecided	Amrith Kumar	OpenStack DBaaS (Trove) next
OpenStack Dashboard (Horizon)	Fix Released	High	Timur Sufiev	OpenStack Dashboard (Horizon) 8.0.0 "liberty"
OpenStack Shared File Systems Service (Manila)	Fix Released	Low	Valeriy Ponomaryov	OpenStack Shared File Systems Service (Manila) 1.0.0 "liberty"
congress	Fix Released	Undecided	Andrey Kurilin
networking-cisco	Fix Released	Undecided	Andrey Kurilin
os-cloud-config	Fix Released	Undecided	Andrey Kurilin

Bug Description

All projects should use only `novaclient.client` as entry point. It designed with some version checks and backward compatibility.
Direct import of versioned client object(i.e. novaclient.v2.client) is a way to "shoot yourself in the foot".

Python-novaclient's doc: http://docs.openstack.org/developer/python-novaclient/api.html

Affected projects:
- Horizon - https://github.com/openstack/horizon/blob/69d6d50ef4a26e2629643ed35ebd661e82e10586/openstack_dashboard/api/nova.py#L31

- Manila - https://github.com/openstack/manila/blob/473b46f6edc511deaba88b48392b62bfbb979787/manila/compute/nova.py#L23

- Cinder- https://github.com/openstack/cinder/blob/de64f5ad716676b7180365798efc3ea69a4fef0e/cinder/compute/nova.py#L23

- Mistral - https://github.com/openstack/mistral/blob/f42b7f5f5e4bcbce8db7e7340b4cac12de3eec4d/mistral/actions/openstack/actions.py#L23

- Congress - https://github.com/openstack/congress/blob/88f4a87f4899fc29e9dde6482ceb2a0e42896ece/contrib/nova/congress.py#L92

See original description

Tags:

Andrey Kurilin (andreykurilin) on 2015-09-08

description:

updated

Andrey Kurilin (andreykurilin) on 2015-09-08

Changed in python-novaclient:
status:	New → Invalid
no longer affects:	python-novaclient

Andrey Kurilin (andreykurilin) on 2015-09-08

description:

updated

Andrey Kurilin (andreykurilin) on 2015-09-09

description:	updated
tags:	added: novaclient

Valeriy Ponomaryov (vponomaryov) on 2015-09-09

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-09: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221687

Changed in manila:
assignee:	nobody → Valeriy Ponomaryov (vponomaryov)
status:	New → In Progress

Valeriy Ponomaryov (vponomaryov) on 2015-09-09

Changed in manila:
importance:	Undecided → Low

Timur Sufiev (tsufiev-x) on 2015-09-09

Changed in horizon:
assignee:	nobody → Timur Sufiev (tsufiev-x)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-09: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221711

Changed in horizon:
status:	New → In Progress

Ivan Kolodyazhny (e0ne) on 2015-09-09

Changed in cinder:
assignee:	nobody → Ivan Kolodyazhny (e0ne)

Andrey Kurilin (andreykurilin) on 2015-09-09

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-09: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/221711
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=27ceba6035c22b7f11e529ddbc287f27568bb8e8
Submitter: Jenkins
Branch: master

commit 27ceba6035c22b7f11e529ddbc287f27568bb8e8
Author: Timur Sufiev <email address hidden>
Date: Wed Sep 9 14:27:34 2015 +0300

Fix usage of python-novaclient in Horizon

    Direct `from novaclient.v2 import client` became source of problems
    since the introduction of microversions in Nova. According to
    novaclient docs, `from novaclient import client` (with the following
    specification of version 2 in Client constructor) is a proper way of
    using it. It should safeguard Horizon against the backward
    incompatibility issues, such as in bug 1493205.

    Change-Id: Ifedd47e8ad6a7aac52549f6e1742dd73fed48da1
    Closes-Bug: #1493576
    Closes-Bug: #1493205

Changed in horizon:
status:	In Progress → Fix Committed

Valeriy Ponomaryov (vponomaryov) on 2015-09-09

Changed in manila:
milestone:	none → liberty-rc1

Zhenguo Niu (niu-zglinux) on 2015-09-09

Changed in mistral:
assignee:	nobody → Zhenguo Niu (niu-zglinux)
description:	updated
Changed in mistral:
status:	New → In Progress

Andrey Kurilin (andreykurilin) on 2015-09-09

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-10: Fix merged to manila (master)

Reviewed: https://review.openstack.org/221687
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=e2ce25778492928524aa9b75a7bd0ea6c8f7e472
Submitter: Jenkins
Branch: master

commit e2ce25778492928524aa9b75a7bd0ea6c8f7e472
Author: Valeriy Ponomaryov <email address hidden>
Date: Wed Sep 9 13:16:12 2015 +0300

Fix usage of novaclient

We should use 'client interface' for initialization of novaclient
instead of direct import of some specific client.

Change-Id: I3172051e4dbba4eb17382cb1393b67829d8c0191
Closes-Bug: #1493576

Changed in manila:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-11: Fix merged to mistral (master)

Reviewed: https://review.openstack.org/221800
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=d5321666a5f9c68be85f49c09f84cc7395fe7e06
Submitter: Jenkins
Branch: master

commit d5321666a5f9c68be85f49c09f84cc7395fe7e06
Author: Zhenguo Niu <email address hidden>
Date: Wed Sep 9 22:27:34 2015 +0800

Fix usage of python-novaclient in Mistral

Change-Id: I33879675aced1905ea0c71c22574cce1064e77d4
Closes-Bug: #1493576

Changed in mistral:
status:	In Progress → Fix Committed

Rob Cresswell (robcresswell-deactivatedaccount) on 2015-09-11

Changed in horizon:
importance:	Undecided → High
milestone:	none → liberty-rc1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-11: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222572

Changed in cinder:
status:	New → In Progress

Ivan Kolodyazhny (e0ne) on 2015-09-11

Changed in cinder:
milestone:	none → liberty-rc1
importance:	Undecided → Medium

Andrey Kurilin (andreykurilin) on 2015-09-11

Changed in mistral:
status:	Fix Committed → Confirmed

Renat Akhmerov (rakhmerov) on 2015-09-14

Changed in mistral:
status:	Confirmed → Fix Committed
milestone:	none → liberty-rc1
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-14: Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223207

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-15: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/222572
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c131767a1997d06e8c616e2192d003ef064c4a30
Submitter: Jenkins
Branch: master

commit c131767a1997d06e8c616e2192d003ef064c4a30
Author: Ivan Kolodyazhny <email address hidden>
Date: Fri Sep 11 14:23:02 2015 +0300

Fix usage of novaclient

We should use 'client interface' for initialization of novaclient
instead of direct import of some specific client.

Change-Id: I51254e20151fe1d6771897e64a8d0bdf2d674d03
Closes-Bug: #1493576

Changed in cinder:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-15: Fix merged to mistral (master)

Reviewed: https://review.openstack.org/223207
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=8c90ee3b7b45ba0dbefb28c298d8c3339226acda
Submitter: Jenkins
Branch: master

commit 8c90ee3b7b45ba0dbefb28c298d8c3339226acda
Author: Christian Berendt <email address hidden>
Date: Mon Sep 14 18:15:15 2015 +0200

get_action_list: use novaclient.client.Client

This solves the following issue:

    ---snip---
    UserWarning: 'novaclient.v2.client.Client' is not designed to be
    initialized directly. It is inner class of novaclient. Please, use
    'novaclient.client.Client' instead.
    ---snap---

Partial-bug: #1493576

Change-Id: Iceca8ccdfaa15108d3ea321ff164975f5f94ae95

Thierry Carrez (ttx) on 2015-09-22

Changed in manila:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-09-24

Changed in cinder:
status:	Fix Committed → Fix Released

Renat Akhmerov (rakhmerov) on 2015-09-25

Changed in mistral:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-09-26

Changed in horizon:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-10-15

Changed in horizon:
milestone:	liberty-rc1 → 8.0.0

Thierry Carrez (ttx) on 2015-10-15

Changed in cinder:
milestone:	liberty-rc1 → 7.0.0

Thierry Carrez (ttx) on 2015-10-15

Changed in manila:
milestone:	liberty-rc1 → 1.0.0

Renat Akhmerov (rakhmerov) on 2015-10-16

Changed in mistral:
milestone:	liberty-rc1 → liberty

Amrith Kumar (amrith) on 2015-10-17

Changed in trove:
assignee:	nobody → Amrith (amrith)
milestone:	none → next

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-17: Fix proposed to trove (master)

#10

Fix proposed to branch: master
Review: https://review.openstack.org/236656

Changed in trove:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-02: Fix merged to trove (master)

#11

Reviewed: https://review.openstack.org/236656
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=ccb39eff61abcd17c12915e08eb5ebceb857a186
Submitter: Jenkins
Branch: master

commit ccb39eff61abcd17c12915e08eb5ebceb857a186
Author: Amrith Kumar <email address hidden>
Date: Sat Oct 17 19:27:44 2015 -0400

Incorrect usage of python-novaclient

    This usage was causing an annoying error message. I've addressed it in
    a configurable way. There's a new config parameter that can be
    changed.

Change-Id: I78832d0bb2ecdc49901b74d3811764a9676f7c8b
Closes-Bug: #1493576

Changed in trove:
status:	In Progress → Fix Committed

Revision history for this message

Thierry Carrez (ttx) wrote on 2015-12-03: Fix included in openstack/trove 5.0.0.0b1

#12

This issue was fixed in the openstack/trove 5.0.0.0b1 development milestone.

Doug Hellmann (doug-hellmann) on 2015-12-03

Changed in trove:
status:	Fix Committed → Fix Released

Andrey Kurilin (andreykurilin) on 2016-06-21

description:	updated
Changed in congress:
assignee:	nobody → Andrey Kurilin (andreykurilin)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-21: Fix proposed to congress (master)

#13

Fix proposed to branch: master
Review: https://review.openstack.org/332420

Andrey Kurilin (andreykurilin) on 2016-06-21

Changed in networking-cisco:
assignee:	nobody → Andrey Kurilin (andreykurilin)
status:	New → In Progress

Andrey Kurilin (andreykurilin) on 2016-06-21

Changed in os-cloud-config:
status:	New → In Progress
assignee:	nobody → Andrey Kurilin (andreykurilin)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-21: Fix proposed to os-cloud-config (master)

#14

Fix proposed to branch: master
Review: https://review.openstack.org/332427

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-23: Fix merged to networking-cisco (master)

#15

Reviewed: https://review.openstack.org/332423
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=4028533aeda842be6576895e7cc8b48f91137aea
Submitter: Jenkins
Branch: master

commit 4028533aeda842be6576895e7cc8b48f91137aea
Author: Andrey Kurilin <email address hidden>
Date: Tue Jun 21 21:38:59 2016 +0300

Fix wrong usage of novaclient

novaclient.client.Client is a documented way to initialize novaclient.
Also, it provides a backward compatible layer.

Change-Id: I4f95356835e043fdaeb5f4f5c96139c54eaa32b3
Closes-Bug: #1493576

Changed in networking-cisco:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-23: Fix merged to congress (master)

#16

Reviewed: https://review.openstack.org/332420
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=57411fec5e44c720381d95e1f7c5f83ebf7a5b0d
Submitter: Jenkins
Branch: master

commit 57411fec5e44c720381d95e1f7c5f83ebf7a5b0d
Author: Andrey Kurilin <email address hidden>
Date: Tue Jun 21 21:27:28 2016 +0300

Fix wrong usage of novaclient

novaclient.client.Client is a documented way to initialize novaclient.
Also, it provides a backward compatible layer.

Change-Id: I9dd15abbeda26c5a6a40139ce47a200720decce8
Closes-Bug: #1493576

Changed in congress:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-13: Fix merged to os-cloud-config (master)

#17

Reviewed: https://review.openstack.org/332427
Committed: https://git.openstack.org/cgit/openstack/os-cloud-config/commit/?id=b8603c8d1db01e54faa9bbe9e4d12f8d9d494e3c
Submitter: Jenkins
Branch: master

commit b8603c8d1db01e54faa9bbe9e4d12f8d9d494e3c
Author: Andrey Kurilin <email address hidden>
Date: Tue Jun 21 21:47:31 2016 +0300

Fix wrong usage of novaclient

novaclient.client.Client is a documented way to initialize novaclient.
Also, it provides a backward compatible layer.

Change-Id: Ibeefe215ff1405d1e6bc478fee415b530813d86c
Closes-Bug: #1493576

Changed in os-cloud-config:
status:	In Progress → Fix Released

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-07-14: Fix included in openstack/congress 4.0.0.0b2

#18

This issue was fixed in the openstack/congress 4.0.0.0b2 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-01: Fix included in openstack/os-cloud-config 5.0.0.0b3

#19

This issue was fixed in the openstack/os-cloud-config 5.0.0.0b3 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/os-cloud-config 5.0.0

#20

This issue was fixed in the openstack/os-cloud-config 5.0.0 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.