VMwareAPI-Team

VMware: instance names can be edited, breaks nova-driver lookup

Bug #1257038 reported by Shawn Hartsock
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Sidharth Surana
OpenStack Compute (nova) 2014.1 "icehouse"
VMwareAPI-Team
Fix Committed
High
Sidharth Surana

Bug Description

Currently the VMware Nova Driver relies on the VM name in vCenter/ESX to match the UUID in Nova. The name can be easily edited by vCenter administrators and break Nova administration of VMs. A better solution should be found allowing the Nova Compute Driver for vSphere to look up VMs by a less volatile and publicly visible mechanism.

EDIT:
A fix would make the link between vSphere and Nova more solid and involve using a vSphere metadata value that cannot be easily edited. Currently the UUID is stored as an extra config metadata property inside vSphere (associated with the instance's virtual-machine) and
this value is not easy to accidentally change. That would make the link much more robust.

See original description
Shawn Hartsock (hartsock)
Changed in nova:
assignee: nobody → Sidharth Surana (ssurana)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59571

Changed in nova:
status: New → In Progress
Shawn Hartsock (hartsock)
Changed in nova:
importance: Undecided → Medium
milestone: none → icehouse-2
Changed in openstack-vmwareapi-team:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Sidharth Surana (ssurana)
Revision history for this message
Shawn Hartsock (hartsock) wrote :

Note: this is an ease of use and robustness fix. It is not a feature fix as no new behaviors will result and the metadata in question has been present since Grizzly release.

description: updated
description: updated
Tracy Jones (tjones-i)
tags: added: grizzly-backport-potential havana-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/59571
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f024b5f9fa0c6b772c597298792b94d01c075384
Submitter: Jenkins
Branch: master

commit f024b5f9fa0c6b772c597298792b94d01c075384
Author: Sidharth Surana <email address hidden>
Date: Wed Nov 27 22:07:16 2013 -0800

    VMware: fix instance lookup against vSphere

    Modifies the logic to search the vsphere vm for a given
    instance. The change now makes use of the config.extraConfig
    property to search for the instance.

    Change-Id: Id11f44b9792f196ad627879d082ad829869efcdf
    Closes-Bug: #1257038

Changed in nova:
status: In Progress → Fix Committed
Sidharth Surana (ssurana)
Changed in openstack-vmwareapi-team:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.