OpenStack-SDK-PHP

composer.json should require PHPUnit

Bug #1295358 reported by Sam Choi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-SDK-PHP
Fix Released
High
mattfarina

Bug Description

We need PHPUnit to run the test suite. Add PHPUnit to the list of requirements in composer.json.

Revision history for this message
mattfarina (mattfarina) wrote :

In addition to missing the dependencies, the composer.lock file should be listed in the .gitignore file.

mattfarina (mattfarina)
Changed in openstack-sdk-php:
importance: Undecided → High
assignee: nobody → mattfarina (mattfarina)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-sdk-php (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82897

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-sdk-php (master)

Reviewed: https://review.openstack.org/82897
Committed: https://git.openstack.org/cgit/stackforge/openstack-sdk-php/commit/?id=e74180781babbd66e35ceaf68e258e58cc8ed931
Submitter: Jenkins
Branch: master

commit e74180781babbd66e35ceaf68e258e58cc8ed931
Author: Matt Farina <email address hidden>
Date: Tue Mar 25 15:20:34 2014 -0400

    Fixing a bug where PHPUnit is not included in the require-dev to run
    the test suite. PHPUnit 4 added and the test suite passes.

    Change-Id: I57f9860127d0a0ac037e31776e5d8a6f233a350e
    Closes-Bug: 1295358

Changed in openstack-sdk-php:
status: In Progress → Fix Committed
mattfarina (mattfarina)
Changed in openstack-sdk-php:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.