Gerritbot does not handle comment events properly.

Bug #1216114 reported by Clark Boylan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
In Progress
Low
Tobias Stevenson

Bug Description

Gerritbot handles patchset created and change merged events properly but it does not report comment events such as -2's. There is code to handle comment events but it is apparently not working. It may be looking for the wrong key in the gerrit event json blob.

Revision history for this message
Edward Raigosa (wenlock) wrote :

The yaml specifies x-vrif-minus-2 for event to look from for gerrit, gerrit uses comment-added for tpe filed from data results. If chanel_config does not also specify comment-added for type in yaml then gerritbot.py will quietly throw away the chanel_set on line 208.

See : http://paste.openstack.org/show/45069/

comment-added could be handled for x-vrif-minus-2 and avoid being chatty if line 146 for the "Compiled Message" is moved to a specific hunt for x-vrif-minus-2 , or some additional def call is added so that the _read loop knows it's searching for comment_added+x-vrif-minus-2 from the yaml.

So you compare for both and avoid going into the comment_added loop all together for a specific call to something new like comment_added_minus2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44326

Changed in openstack-ci:
assignee: nobody → Tobias Stevenson (tstevenson)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gerritbot (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44913

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.