gerritbot should be interruptable
Bug #1021696 reported by
Andrew Hutchings
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Core Infrastructure |
Triaged
|
Medium
|
Tim Kelsey |
Bug Description
at the moment the only way to stop gerritbot is a kill -9. It should have a proper signal handler to take normal kills and nohups and clean up it's pid file. This may require having everything in threads so the main thread can handle signals
Changed in openstack-ci: | |
status: | New → Triaged |
milestone: | folsom → grizzly |
Changed in openstack-ci: | |
assignee: | nobody → Elizabeth Krumbach (lyz) |
Changed in openstack-ci: | |
milestone: | grizzly → havana |
tags: | added: low-hanging-fruit |
Changed in openstack-ci: | |
assignee: | Elizabeth Krumbach Joseph (lyz) → nobody |
Changed in openstack-ci: | |
assignee: | Jeremy Stanley (fungi) → nobody |
Changed in openstack-ci: | |
milestone: | icehouse → kilo |
To post a comment you must log in.
I think this will be fixed by pushing and using a new gerritlib release. Lifeless, made the gerritlib listener thread a daemon thread so that if the main thread exits so will the entire program. We should work on getting a new gerritlib release out and test this theory.