OpenStack Core Infrastructure

update_bug should use review owner instead of latest commiter

Bug #1011705 reported by Monty Taylor
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Confirmed
Low
Ricardo Carrillo Cruz

Bug Description

On 06/08/2012 06:23 PM, Brian Waldon wrote:
> I'm of the opinion that whatever is calling update_bug.py (I forget what repo its in) should be giving it the review owner rather than the last review committer as its argument. Agree?

Also:

James Blair wrote:
zuul/lib/gerrit.py wants to be an independent gerrit API library in
Python but I haven't split it out yet. Depending on when this gets
implemented for update_bug, you may want to use it or temporarily copy
it along with update_bug. It should handle some of the boilerplate
around querying gerrit for information about the change.

Monty Taylor (mordred)
Changed in openstack-ci:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

The script is in openstack-ci-puppet.

barumuga@lexpad:~/projects/openstack-ci-puppet$ find . -name update_bug.py
./modules/gerrit/files/scripts/update_bug.py

This is called from a gerrit hook. The hook doesn't seem to be stored in git, yet. We should fix the hook to pass review-owner to this script.

Thierry Carrez (ttx)
tags: added: update-bug
removed: gerrit
Monty Taylor (mordred)
Changed in openstack-ci:
milestone: folsom → grizzly
Thierry Carrez (ttx)
tags: added: updatebug
removed: update-bug
Revision history for this message
Thierry Carrez (ttx) wrote :

The current hook doesn't get enough information to use the review owner.

Long-term plan is to rewrite updatebug into a gerrit streamevents daemon, which would apparently provide us enough information.

Changed in openstack-ci:
assignee: Thierry Carrez (ttx) → nobody
Monty Taylor (mordred)
Changed in openstack-ci:
milestone: grizzly → none
Clark Boylan (cboylan)
tags: added: low-hanging-fruit
Changed in openstack-ci:
importance: Medium → Low
Khai Do (zaro0508)
Changed in openstack-ci:
assignee: nobody → Khai Do (zaro0508)
Revision history for this message
Khai Do (zaro0508) wrote :

Currently the update_bug script is in jeepyb project. It gets called from the following config scripts:
 - http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/change-merged
 - http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/templates/gerrit_patchset-created.erb

Thierry is correct, Gerrit does not provide info about the change owner in the hooks for us to pass to the update_bug script -> https://gerrit-review.googlesource.com/Documentation/config-hooks.html

An upstream bug has been created to add change owner info to the Gerri -> hooks: https://code.google.com/p/gerrit/issues/detail?id=2596

Changed in openstack-ci:
status: Triaged → Confirmed
Revision history for this message
Khai Do (zaro0508) wrote :

upstream change to add change owner to gerrit hooks: https://gerrit-review.googlesource.com/#/c/56252

Ricardo Carrillo Cruz (rcarrillocruz)
Changed in openstack-ci:
assignee: Khai Do (zaro0508) → Ricardo Carrillo Cruz (rcarrillocruz)
Revision history for this message
Khai Do (zaro0508) wrote :

change 56252 has been merged and gerrit with that change has been updated on review-dev.o.o

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.