OpenSRF

Teach srfsh how to read the actual router name

Bug #1888406 reported by Mike Rylander
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Confirmed
Undecided
Unassigned

Bug Description

All OpenSRF versions.

OpenSRF routers have a default XMPP user name of "router", but that can be changed. Unfortunately, srfsh doesn't know how to use the router name from the config when sending router-specific commands such as introspection calls. It should be able to do that.

Branch forthcoming.

Revision history for this message
Mike Rylander (mrylander) wrote :

Branch available at:

https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/miker/lp-1888406-srfsh-router-name

tags: added: pullrequest
Changed in opensrf:
assignee: Mike Rylander (mrylander) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Wouldn't strlen(router_name) need to be added to the calculation of len to avoid the result being too short?

Revision history for this message
Mike Rylander (mrylander) wrote :

Galen, very much so!

I've force-pushed an update to the branch that adds the length of the router name.

Thanks!

Revision history for this message
Jason Boyer (jboyer) wrote :

I've tried this and it works as expected to contact routers who have more interesting names than just "router." Signoff branch is here: https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/jboyer/lp1888406_signoff / working/user/jboyer/lp1888406_signoff

Jason Boyer (jboyer)
tags: added: signedoff
Changed in opensrf:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.