effects in real time

Thanks a lot.

I've tried out this patch, but I found that too often a continuous press of the spinbutton would cause a crash, as it's then regenerating the xml file, and updating the preview many times a second. It would be a useful thing to have though, so we'll have to look at it again and see if there's a way to reduce the calls that are made.

This patch has a problem if it generates the xml while generating the image fails.

It could create a sign to warn when he can generate the xml.

I am currently working on a patch and will attach it soon. All I did was add a timer to call a modified version of RefreshPreview() every second. It is a crude patch, but it works. This bug has made me mad for too long :)

Does that work the cpu would not do without?

I think it would have to create a signal (true or false) that every x milliseconds revision. If you modify an effect, this changes the signal to true. If after reviewing the signal, this is true, the preview is generated, and passed the signal to false. If after reviewing the signal, this is false, nothing is done.

This would cause the processor only when amending trabajase effect.

If I remember correctly, the problem is that if you generate the preview before it is generated xml fails.

The interesting thing would be that the modification of the effect, would create the xml, and once created the xml is changed to true signal.

And while the signal is in true (generating the preview) to effect change can not call to create a new xml, not to create a break in the preview.

Once again, this patch works but it is not very good. I would like feedback and I would love for people to test it. Thanks.

Already found a bug. With multiple effects, openshot crashes due to calling GenerateXML() too many times in too short of a period.

Thanks a lot for this patch Michael.

I'm going to put it in the last milestone but that's not sure that it will be put it because this one is nearly closed.

Please, if you have found another bug open another bug report. This one will be closed if the pathc is approved and put in the milestone.

Thx.

What I did not know when I posted my bug was that GenerateXML() is called for every effect! I have changed some code so that the timer waits a proportional amount of time as there are effects. For example, if there is one effect, it waits 1.5 seconds. If there are two effects it waits 2.5 seconds and so on (this of course can be changed and these are arbitrary numbers).

I would like to add a spinner or a loading symbol of some sort, but I am very unfamiliar with GTK. If someone would like to add a spinning wheel, I could easily call a function to start/stop it when values change and when the timer fires.

Cenwen,
I will open a bug report for the next bug that I find (trust me, there are many in my code!)