Odoo Server (MOVED TO GITHUB)

openerp source package lacks dependencies on python-setuptools and python-pybabel

Bug #985381 reported by Stuart Longland on 2012-04-19

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Server (MOVED TO GITHUB)	Confirmed	Low	OpenERP's Framework R&D

Bug Description

As per the description, if someone tries to build a .deb package of OpenERP on a vanilla Ubuntu system, the following error is emitted:

vrtadmin@openerp-dev:~/work/openerp/branches/openerp-vrt-6.1-1-calendaring$ dpkg-buildpackage
dpkg-buildpackage: set CFLAGS to default value: -g -O2
dpkg-buildpackage: set CPPFLAGS to default value:
dpkg-buildpackage: set LDFLAGS to default value: -Wl,-Bsymbolic-functions
dpkg-buildpackage: set FFLAGS to default value: -g -O2
dpkg-buildpackage: set CXXFLAGS to default value: -g -O2
dpkg-buildpackage: source package openerp-vrt
dpkg-buildpackage: source version 6.1-1-1
dpkg-buildpackage: source changed by Stuart Longland <email address hidden>
dpkg-buildpackage: host architecture i386
fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
Traceback (most recent call last):
  File "setup.py", line 23, in <module>
    import glob, os, re, setuptools, sys
ImportError: No module named setuptools
dh_auto_clean: python setup.py clean -a returned exit code 1
make: *** [clean] Error 1
dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2
vrtadmin@openerp-dev:~/work/openerp/branches/openerp-vrt-6.1-1-calendaring$

If they install python-setuptools, they'll get hit with another complaining about a missing module called babel.

Attached is an updated debian/control file which lists these as build-time dependencies.

Related branches

lp://staging/~bitglue/openobject-server/fix-debian-builddeps

Ready for review for merging into lp://staging/openobject-server

Phil Frost (community): Approve on 2013-01-03

OpenERP Core Team: Pending requested 2013-01-03

Revision history for this message

Stuart Longland (redhatter) wrote on 2012-04-19:

Updated debian/control file Edit (538 bytes, text/plain)

Revision history for this message

Amit Bhavsar (Open ERP) (amb-openerp) wrote on 2012-04-30:

Hello Stuart Longland,

I have tested your scenario and patch also, But it's not solved the error. "python-setuptools" and "python-pybabel" is depended package. It's must be installed. If It's not Installed, Definitely throw the same error(No module named setuptools).
If I am not apply this patch and then face the same error. If I am apply this patch and then also face the same error.
So what is meaning of this code.........;-)
What You SaY about this!!!

Thanks and waiting for your reply!

Changed in openobject-server:
status:	New → Incomplete

Revision history for this message

Stuart Longland (redhatter) wrote on 2012-04-30:

The difference is... with the patch applied, running dpkg-buildpackage, it is Debian's package system that tells you what packages you're missing.

Without the patch, it's the build system that tells you.

The difference? Someone can add OpenERP source packages to an APT repository, a user adds that source repository, then does `apt-get source -b openerp`, sees the failure, and *has to manually intervene*.

With the patch in Comment #1: Someone runs `apt-get source -b openerp`. APT sees that python-pybabel and python-setuptools are dependencies, automatically installs them, *then* downloads and compiles OpenERP.

Surely a better plan, no?

Revision history for this message

Amit Bhavsar (Open ERP) (amb-openerp) wrote on 2012-05-02:

Hello Stuart Longland,

Yes ..... It's better plan! :-) That's why I am confirm this Issue with low priority.
And I request to Antony that, you please review it.

Thanks!

Changed in openobject-server:
status:	Incomplete → Confirmed
importance:	Undecided → Low
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)

Revision history for this message

Patrick Schmucki (patrick.schmucki) wrote on 2012-12-30:

For all the people downloading the latest source tarball from http://v6.openerp.com/downloads (actually points to http://nightly.openerp.com/6.1/releases/openerp-6.1-latest.tar.gz) it's still a problem.

The server installation documentation doesn't tell us, that we need to
-> sudo apt-get install python-setuptools
too. Otherwise, the install command
-> sudo python setup.py install
will fail with the error:

Traceback (most recent call last):
File "setup.py", line 23, in <module>
import glob, os, re, setuptools, sys
ImportError: No module named setuptools

Revision history for this message

Phil Frost (bitglue) wrote on 2013-01-03:

I've applied Stuart's patch as a branch at lp:~bitglue/openobject-server/fix-debian-builddeps