Odoo Server (MOVED TO GITHUB)

6.0.2 Multicompany - Product Default Tax (ir.values) only for one company?

Bug #817430 reported by conexus.at on 2011-07-28

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Invalid	Low	Unassigned
	Odoo Server (MOVED TO GITHUB)	Fix Committed	Low	OpenERP's Framework R&D

Bug Description

Hello,

If you setup two companies (A, then B) in 6.0.2 with differnt Chart of Accounts and then

- create a Product with a User from Company B, the Default Tax is applied.
- create a Product with a User from Company A, NO Default Tax is applied.

It seems like the Records (taxes_id, supplier_taxes) in ir.values from Company A are being replaced while configuring the second Chart of Accounts for Company B.

with kind regards,

Tags:

Related branches

lp://staging/~openerp-dev/openobject-addons/trunk-bug-817430-ara

Rejected for merging into lp://staging/openobject-addons

Olivier Dony (Odoo): Disapprove on 2011-09-05

Mustufa Rangwala (Open ERP) (community): Approve on 2011-08-02

qdp (OpenERP): Pending requested 2011-08-02

lp://staging/~openerp-dev/openobject-server/trunk-bug-817430-nch

Rejected for merging into lp://staging/openobject-server

Olivier Dony (Odoo): Pending requested 2011-08-30

Vo Minh Thu: Pending requested 2011-08-30

lp://staging/~openerp-dev/openobject-server/trunk-cleanup-ir-values

Merged into lp://staging/openobject-server at revision 3713

Naresh(OpenERP): Pending requested 2011-09-02

OpenERP Core Team: Pending requested 2011-09-02

Revision history for this message

conexus.at (conexus.at) wrote on 2011-07-28:

For Testing I added replace=False to the ir_values.set calls in wizard_multi_charts_accounts.
After that there are Default Tax Records created for both Companies in ir.values.
But ir.values.get doesn't seem to filter on the company_id, I only get the first record returned that has been found...?

Revision history for this message

Dhruti Shastri(OpenERP) (dhs-openerp) wrote on 2011-07-29:

multi_chart.ogv Edit (9.8 MiB, video/ogg)

Hello conexus ,

The problem seems to come from account it self as the values are overwritten by the prior Account chart, so it always show the values to the user for latest Chart of Account.

Attached video confirms the bug.

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance:	Undecided → Low
status:	New → Confirmed

Ashvin Rathod (OpenERP) (ara-tinyerp) on 2011-07-29

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Ashvin Rathod (OpenERP) (ara-tinyerp) wrote on 2011-08-01:

Hello,

I have committed the related changes to the addons, But this bug also need to fix from server side.

For Testing I have pass current chart company to the ir_values.set calls in wizard_multi_charts_accounts but its replace by current user company from ir_values.set and ir_values.get is not filter by company.

Thanks,
ara

Changed in openobject-addons:
status:	In Progress → Fix Committed

Amit Parik (amit-parik) on 2011-08-01

Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance:	Undecided → Low
status:	New → Confirmed

Mustufa Rangwala (Open ERP) (mra-tinyerp) on 2011-08-02

Changed in openobject-addons:
milestone:	none → 6.1

Naresh(OpenERP) (nch-openerp) on 2011-08-30

Changed in openobject-server:
status:	Confirmed → Triaged
status:	Triaged → In Progress

Revision history for this message

Naresh(OpenERP) (nch-openerp) wrote on 2011-08-30:

Hello conexus,

Thanks for reporting !

The server issue has been fixed at lp:~openerp-dev/openobject-server/trunk-bug-817430-nch and will be mered soon to the trunk server.

please provide your feedback !
Thanks,

Changed in openobject-server:
status:	In Progress → Fix Released
status:	Fix Released → Fix Committed

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2011-09-05:

After further analysis, this issue should be fixed exclusively in the server, and should not require any patch in addons.
The previously proposed patches have been rejected, and a complete fix is available for the server in the following branch: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-cleanup-ir-values

The bug will also be marked "invalid" for the "Addons" project, as it only affects the framework (OpenERP Server project).

Any test/feedback would be appreciated, as this new branch covers a deeper review/cleanup of default values processing, and other related internal structures.

Thanks!

PS: the fixed branch is available for live testing for a limited time on our runbot: http://server-trunk-cleanup-ir-values.runbot.openerp.com:9329 (port 9229 for XMLRPC)

Changed in openobject-addons:
assignee:	OpenERP R&D Addons Team 3 (openerp-dev-addons3) → nobody
status:	Fix Committed → Invalid
milestone:	6.1 → none

Revision history for this message

conexus.at (conexus.at) wrote on 2011-09-16:

Thanks for the fix!

Will the fix be merged only to 6.1 or also to 6.0.x?

with kind regards,
Sven

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2011-09-16: Re: [Bug 817430] Re: 6.0.2 Multicompany - Product Default Tax (ir.values) only for one company?

On 09/16/2011 01:54 PM, conexus.at wrote:
> Will the fix be merged only to 6.1 or also to 6.0.x?

In order to continuously improve the framework, this fix was implemented
as part of a larger refactoring and cleanup (as can be seen in the merge
proposal).
This refactoring will not be merged in 6.0, as it would be against the
stable series policy - too risky.
However, following our bug management process, any OpenERP Enterprise
customer could request fixing this bug in 6.0, in which case a safer
minimalist fix will be implemented for 6.0.

I hope this helps...

Rifakat Husen (OpenERP) (rha-openerp) on 2011-12-08

tags:

added: maintenance