Odoo Server (MOVED TO GITHUB)

[trunk/7.0]format_layout from model res.partner.bank.type must not be translated

Bug #1172156 reported by Yann Papouin on 2013-04-24

This bug affects 1 person

	Status	Importance	Assigned to
Odoo Server (MOVED TO GITHUB)	Confirmed	Low	OpenERP's Framework R&D
OpenERP Community Backports (Server)	Status tracked in 7.0
6.1	Fix Released	Low	Yann Papouin
7.0	Fix Released	Low	Yann Papouin

Bug Description

The format layout field that is used to format the name_get text of the "res.partner.bank.type" model must not be translated.
After editing this text, in the data xml or directly the database, you have to delete the translation linked to this field to make your changes effective.

eg: Try to remove the BIC part from iban, edit base_iban_data.xml from base_iban

from:
<field name="format_layout">%(bank_name)s: IBAN %(acc_number)s - BIC %(bank_bic)s</field>
to:
<field name="format_layout">%(bank_name)s: IBAN %(acc_number)s</field>

Related branches

lp://staging/~openerp-dev/openobject-addons/trunk-bug-1172156-sejal

Ready for review for merging into lp://staging/openobject-addons

Stefan Rijnhart (Opener) (community): Disapprove on 2013-08-03

Amit Parik (community): Disapprove on 2013-05-31

OpenERP Core Team: Pending requested 2013-05-31

lp://staging/~yann-papouin/openobject-server/6.1-bug-1172156-bank-format-layout-translation

Ready for review for merging into lp://staging/openobject-server/6.1

OpenERP Core Team: Pending requested 2013-09-11

lp://staging/~yann-papouin/ocb-server/6.1-bug-1172156-bank-format-layout-translation

Merged into lp://staging/ocb-server/6.1 at revision 4326

Holger Brunn (Therp): Approve (code review) on 2014-02-03

Alexandre Fayolle - camptocamp: Approve (code review, no test) on 2014-02-03

Pedro Manuel Baeza: Approve (code review) on 2014-01-31

lp://staging/~yann-papouin/openobject-server/7.0-bug-1172156-bank-format-layout-translation

Ready for review for merging into lp://staging/openobject-server/7.0

OpenERP Core Team: Pending requested 2014-03-10

lp://staging/~yann-papouin/ocb-server/7.0-bug-1172156-bank-format-layout-translation

Merged into lp://staging/ocb-server at revision 5290

Pedro Manuel Baeza: Approve (code review) on 2014-03-10

Sandy Carter (http://www.savoirfairelinux.com): Approve (code review) on 2014-03-10

Holger Brunn (Therp): Approve (code review) on 2014-03-10

Twinkle Christian(OpenERP) (tch-openerp) on 2013-04-29

affects:	openobject-addons → openobject-server
Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance:	Undecided → Low
status:	New → Confirmed
summary:	- format_layout from model res.partner.bank.type must not be translated + [trunk/7.0]format_layout from model res.partner.bank.type must not be + translated

Revision history for this message

Amit Parik (amit-parik) wrote on 2013-05-15:

Hello Yann,

Today I am going to fix this issue, but I could not understand why you want to remove the bank_bic in format field.

I seen that the res.partner.bank.type has translatable name field, Would you please provide more information on this.

Thanks and waiting for your reply!

Changed in openobject-server:
assignee:	OpenERP's Framework R&D (openerp-dev-framework) → nobody
status:	Confirmed → Incomplete

Sejal Bhut(OpenERP Trainee) (sejal.bhut-openerp-deactivatedaccount) on 2013-05-31

Changed in openobject-server:
status:	Incomplete → In Progress

Revision history for this message

Sejal Bhut(OpenERP Trainee) (sejal.bhut-openerp-deactivatedaccount) wrote on 2013-05-31:

Hello,

It has been fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1172156-sejal branch.
Revision No: 8727
Revision ID: <email address hidden>

Thanks,
Sejal.

Changed in openobject-server:
status:	In Progress → Fix Committed

Revision history for this message

Amit Parik (amit-parik) wrote on 2013-05-31:

Hello Sejal,

Your fix doesn't related with this bug report. Please make sure bug is confirmed before the fixing because I am not sure yet its bug or not, So would you please wait until the bug is confirmed.

Thanks for understanding!

Changed in openobject-server:
status:	Fix Committed → Incomplete

Revision history for this message

Yann Papouin (yann-papouin) wrote on 2013-06-03:

Amit Parik, the fix seems correct and the bug was confirmed.

Removing the BIC part was just an example to show that editing the xml do not have any effect on the translated value and, as a consequence, on the report.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-08-03:

[Expired for OpenERP Server because there has been no activity for 60 days.]

Changed in openobject-server:
status:	Incomplete → Expired

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2013-08-03:

Resetting to 'confirmed'. I agree with Amit Parik that the proposed solution sets the wrong field to 'not translatable'.

Changed in openobject-server:
status:	Expired → Confirmed

Amit Parik (amit-parik) on 2013-08-05

Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)

Yann Papouin (yann-papouin) on 2014-01-31

Changed in ocb-server:
assignee:	nobody → Yann Papouin (yann-papouin)
status:	New → Fix Committed
status:	Fix Committed → New
assignee:	Yann Papouin (yann-papouin) → nobody

Yann Papouin (yann-papouin) on 2014-03-10

Changed in ocb-server:
assignee:	nobody → Yann Papouin (yann-papouin)
status:	New → Fix Committed

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.