Comment 2 for bug 782194

Revision history for this message
Graeme Gellatly (gdgellatly) wrote : Re: [Bug 782194] [NEW] [PS] Impossible to know which journal to select in a Customer Payment with a multi-company context

This is only really an issue when you have access to more than one company.

To resolve this internally we did the following.

Created a new field in res.company called short_name.
Updated execute function in wizard,multi,chartofaccounts to append this
short name to the Journal name if new field sep_multi_seq was checked.

We also had to duplicate sequneces and add company_id to prefix on sequences
to keep them unique.
Change the analytic journal search to not just return any journal, but only
journals for the company, otherwise in multicompany it assigns the first
analytic journal it finds to sale.
Update spelling of analytical as it is incorrect everywhere.

We also did the following to help with multicompany chart codes

Added a prefix and suffix field to the wizard to prepend or append a code to
account.account code from template.

Update views accordingly.

While doing this work it is worth noting that execute is give or take 400
line function, with the same behaviour carried out in different ways, and
the same variables redeclared unnecessarily in places and old code commented
out rather than deleted. It should probably be refactored, so when making
changes like the above you don't end up with a big chunk of cut and paste.

If anyone is interested then I can supply the changes we made to those 2,
but it is tied up in a module that needs to do a lot more for localisation
reasons.

On Sat, May 14, 2011 at 2:16 AM, Bogdan Stanciu <
<email address hidden>> wrote:

> On 13. 05. 11 15:02, Harmel Delphine (OpenERP) wrote:
> > Public bug reported:
> >
> > trunk server revno 3411
> >
> > * Having two companies with different chart of account (example one with
> the Belgium Chart of Account, the second one with the French Chart of
> account)
> > * The system automatically creates several "Current" journals
> >
> > * Accounting/Customers/Customer Invoices, select an invoice, validate it
> and click on "Payment"
> > * The system opens the Customer Payment view and ask to fill in the
> "Payment method" field (which is in fact a journal !!!)
> >
> > Obtained result : Impossible to know to which company is related the
> > "Current" journal so you select anyone but then you can't validate the
> > payment and if you go back to the list view it saves the payment with no
> > lines in it
> >
> > Expected result : it displays the journal linked to the current company
> (or identified the journal ) so that we now
> > which journal to choose
> >
> > reported by dha, OpenERP PRof Serv.
> >
> > ** Affects: openobject-addons
> > Importance: Medium
> > Assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3)
> > Status: Confirmed
> >
> >
> > ** Tags: profserv
> >
> > ** Changed in: openobject-addons
> > Assignee: (unassigned) => OpenERP R&D Addons Team 3
> (openerp-dev-addons3)
> >
> quick fix: name specifically your journals (payment method), so you can
> avoid confusion.
>
> of course, this is NOT the solution, but just a "survival" method, if I
> may :-)
>
> bogdan
>
> --
> You received this bug notification because you are subscribed to OpenERP
> Addons.
> https://bugs.launchpad.net/bugs/782194
>
> Title:
> [PS] Impossible to know which journal to select in a Customer Payment
> with a multi-company context
>
> Status in OpenERP Modules (addons):
> Confirmed
>
> Bug description:
> trunk server revno 3411
>
> * Having two companies with different chart of account (example one with
> the Belgium Chart of Account, the second one with the French Chart of
> account)
> * The system automatically creates several "Current" journals
>
> * Accounting/Customers/Customer Invoices, select an invoice, validate it
> and click on "Payment"
> * The system opens the Customer Payment view and ask to fill in the
> "Payment method" field (which is in fact a journal !!!)
>
> Obtained result : Impossible to know to which company is related the
> "Current" journal so you select anyone but then you can't validate the
> payment and if you go back to the list view it saves the payment with
> no lines in it
>
> Expected result : it displays the journal linked to the current company
> (or identified the journal ) so that we now
> which journal to choose
>
> reported by dha, OpenERP PRof Serv.
>