Odoo Addons (MOVED TO GITHUB)

mrp_repair doesn't work with products with lot tracking

Bug #695343 reported by Manu on 2010-12-29

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP R&D Addons Team 2	Odoo Addons (MOVED TO GITHUB) 6.0

Bug Description

I'm using v5.0.15

All my products have the fields "Track production, incoming and outgoing lots" checked.

To reproduce it, create a new repair, add products in the operations list (the type doesn't matter) and different select source and destination locations (for example, from the main stock location to the repair location). Then try to finish the repair and the following error pops up:

"ValidateError

Error occurred while validating the field(s) prodlot_id: You must assign a production lot for this product."

There is no way to enter the product lot in the operations line so the system tries to create a stock move without product lot and as the product lot is required it fails, so mrp_repair is useless for products that require lot tracking.

Related branches

lp://staging/~openerp-dev/openobject-addons/ksa-addons2

Merged into lp://staging/~openerp-dev/openobject-addons/trunk-dev-addons2 at revision 4015

OpenERP Core Team: Pending requested 2011-02-15

Merged into lp://staging/~openerp/openobject-addons/trunk-fix-osvmem-read at revision 4401

OpenERP Core Team: Pending requested 2011-02-07

Diff: 18611 lines (+5387/-1667)

166 files modified

account/account.py (+1/-1)
account/account_bank_statement.py (+1/-3)
account/i18n/gl.po (+4/-2)
account/i18n/it.po (+24/-5)
account/i18n/pt_BR.po (+7/-3)
account/i18n/ru.po (+64/-46)
account/i18n/zh_CN.po (+14/-12)
account/invoice.py (+1/-60)
account/project/project_view.xml (+2/-2)
account/report/account_balance.py (+2/-2)
account/report/account_balance_landscape.py (+0/-1)
account/report/account_balance_sheet.py (+2/-2)
account/report/account_partner_balance.py (+0/-1)
account/report/account_profit_loss.py (+2/-2)
account/wizard/account_state_open.py (+1/-1)
account/wizard/account_use_model.py (+1/-1)
account_accountant/i18n/gl.po (+37/-0)
account_analytic_analysis/i18n/gl.po (+17/-10)
account_analytic_default/i18n/gl.po (+34/-13)
account_analytic_default/i18n/hu.po (+4/-4)
account_analytic_plans/i18n/gl.po (+70/-36)
account_analytic_plans/i18n/hu.po (+6/-6)
account_budget/i18n/zh_CN.po (+18/-18)
account_cancel/i18n/gl.po (+37/-0)
account_followup/i18n/pt_BR.po (+76/-43)
account_invoice_layout/i18n/hu.po (+18/-4)
account_payment/wizard/account_payment_create_order_view.xml (+1/-0)
account_voucher/account_voucher.py (+0/-2)
account_voucher/voucher_payment_receipt_view.xml (+1/-1)
analytic/analytic.py (+5/-5)
association/i18n/hu.po (+11/-4)
auction/i18n/es.po (+7/-7)
base_calendar/i18n/es_EC.po (+39/-35)
base_calendar/i18n/hu.po (+16/-16)
base_contact/i18n/ro.po (+4/-4)
base_iban/i18n/ro.po (+9/-4)
base_module_quality/i18n/hu.po (+3/-3)
base_module_quality/i18n/pt_BR.po (+22/-2)
base_report_creator/i18n/hu.po (+35/-26)
base_report_creator/i18n/zh_CN.po (+6/-6)
base_report_designer/i18n/hu.po (+4/-4)
base_report_designer/i18n/zh_CN.po (+12/-2)
base_setup/i18n/hu.po (+20/-19)
base_vat/i18n/hu.po (+4/-3)
board/i18n/gl.po (+37/-37)
board/i18n/hu.po (+6/-6)
crm/i18n/hu.po (+34/-32)
crm/i18n/pt_BR.po (+5/-5)
crm_caldav/i18n/pt_BR.po (+5/-5)
crm_claim/i18n/hu.po (+4/-4)
crm_claim/i18n/pt_BR.po (+1/-1)
crm_claim/i18n/tr.po (+749/-0)
crm_fundraising/i18n/hu.po (+8/-8)
crm_fundraising/i18n/pt_BR.po (+1/-1)
crm_helpdesk/i18n/hu.po (+5/-5)
crm_partner_assign/i18n/hu.po (+17/-13)
crm_partner_assign/i18n/pt_BR.po (+1/-1)
crm_profiling/i18n/hu.po (+3/-3)
crm_profiling/i18n/pt_BR.po (+1/-1)
crm_profiling/i18n/sv.po (+1/-1)
decimal_precision/i18n/hu.po (+3/-3)
delivery/i18n/hu.po (+54/-35)
document/i18n/hu.po (+12/-12)
document_ftp/i18n/hu.po (+5/-5)
document_ics/i18n/hu.po (+6/-4)
document_webdav/i18n/hu.po (+3/-3)
email_template/i18n/hu.po (+6/-4)
email_template/i18n/pt_BR.po (+1/-1)
event/i18n/hu.po (+25/-16)
event/i18n/pt_BR.po (+24/-6)
event_project/i18n/hu.po (+4/-4)
hr/i18n/hu.po (+36/-28)
hr_attendance/i18n/hu.po (+12/-12)
hr_contract/i18n/hu.po (+15/-11)
hr_evaluation/i18n/hu.po (+3/-3)
hr_expense/hr_expense.py (+3/-2)
hr_expense/i18n/hu.po (+10/-9)
hr_holidays/hr_holidays.py (+3/-3)
hr_holidays/hr_holidays_view.xml (+1/-0)
hr_holidays/i18n/hu.po (+3/-3)
hr_holidays/report/available_holidays_view.xml (+1/-0)
hr_payroll/i18n/hu.po (+50/-40)
hr_payroll/report/report_payroll_advice.rml (+2/-2)
hr_payroll_account/i18n/hu.po (+10/-9)
hr_payroll_account/i18n/it.po (+4/-4)
hr_recruitment/__openerp__.py (+1/-1)
hr_recruitment/i18n/hu.po (+16/-16)
hr_timesheet/i18n/hu.po (+22/-11)
hr_timesheet/wizard/hr_timesheet_print_employee.py (+3/-1)
hr_timesheet_invoice/i18n/hu.po (+7/-7)
hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py (+3/-0)
hr_timesheet_sheet/i18n/hu.po (+51/-13)
idea/i18n/hu.po (+10/-7)
knowledge/i18n/hu.po (+17/-5)
l10n_ch/i18n/pt_BR.po (+4/-4)
l10n_ch/test/l10n_ch_report.yml (+8/-4)
l10n_ch/wizard/create_dta.py (+1/-1)
l10n_fr/fr_pcg_taxes_demo.xml (+3/-3)
marketing_campaign/i18n/hu.po (+3/-3)
membership/i18n/hu.po (+3/-3)
membership/i18n/pt_BR.po (+29/-29)
mrp/i18n/es_AR.po (+140/-101)
mrp/i18n/hu.po (+47/-43)
mrp/i18n/ro.po (+207/-90)
mrp/mrp.py (+2/-1)
mrp/wizard/mrp_product_produce.py (+2/-2)
mrp_operations/i18n/hu.po (+7/-7)
mrp_operations/i18n/ro.po (+31/-17)
mrp_repair/i18n/hu.po (+8/-8)
mrp_subproduct/i18n/hu.po (+3/-3)
multi_company/i18n/hu.po (+18/-3)
pad/i18n/hu.po (+3/-3)
process/i18n/hu.po (+3/-3)
procurement/i18n/hu.po (+8/-8)
procurement/i18n/nl.po (+98/-68)
procurement/i18n/ro.po (+4/-4)
procurement/procurement_view.xml (+3/-2)
product/i18n/hu.po (+7/-7)
product/i18n/id.po (+105/-55)
product/i18n/pt_BR.po (+4/-4)
product/i18n/ro.po (+9/-7)
product/i18n/zh_CN.po (+3/-3)
product/pricelist.py (+1/-1)
product_expiry/i18n/tr.po (+176/-0)
project/i18n/hu.po (+4/-3)
project_mrp/project_procurement.py (+1/-1)
project_scrum/wizard/project_scrum_backlog_create_task.py (+3/-0)
project_scrum/wizard/project_scrum_backlog_sprint.py (+3/-0)
purchase/purchase.py (+1/-1)
purchase_analytic_plans/i18n/hu.po (+5/-5)
purchase_requisition/i18n/ca.po (+410/-0)
purchase_requisition/wizard/purchase_requisition_partner.py (+5/-1)
report_designer/i18n/ca.po (+98/-0)
report_intrastat/i18n/hu.po (+16/-12)
report_webkit/i18n/ca.po (+560/-0)
report_webkit_sample/i18n/ca.po (+143/-0)
report_webkit_sample/i18n/hu.po (+6/-6)
resource/i18n/ca.po (+346/-0)
sale/i18n/hu.po (+65/-14)
sale/i18n/pt_BR.po (+4/-4)
sale/i18n/ro.po (+6/-6)
sale/sale.py (+19/-15)
sale_analytic_plans/i18n/hu.po (+8/-4)
sale_crm/i18n/hu.po (+10/-9)
sale_journal/i18n/hu.po (+33/-2)
sale_layout/i18n/ca.po (+292/-0)
sale_layout/i18n/hu.po (+26/-16)
sale_layout/i18n/ro.po (+5/-5)
sale_margin/i18n/hu.po (+16/-7)
sale_mrp/i18n/ca.po (+66/-0)
sale_mrp/i18n/hu.po (+4/-4)
sale_order_dates/i18n/ca.po (+70/-0)
stock/i18n/hu.po (+20/-16)
stock/i18n/id.po (+32/-29)
stock/i18n/ro.po (+92/-92)
stock/i18n/zh_CN.po (+23/-23)
stock/stock.py (+12/-10)
stock/wizard/stock_invoice_onshipping.py (+2/-2)
stock/wizard/stock_location_product.py (+1/-1)
stock/wizard/stock_partial_picking.py (+19/-3)
stock/wizard/stock_return_picking.py (+1/-1)
stock_planning/i18n/hu.po (+36/-27)
subscription/i18n/hu.po (+5/-5)
survey/i18n/hu.po (+15/-14)
warning/i18n/hu.po (+15/-15)
wiki/i18n/hu.po (+3/-3)

Amit Parik (amit-parik) on 2010-12-30

Changed in openobject-addons:
assignee:	nobody → Jay (OpenERP) (jvo-openerp)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Manu (manu-tiedra) wrote on 2010-12-30:

I won't mark the importance as Low. Probably Medium would be more accurate.

There are a lot of industries that require product lot tracing.

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2010-12-31:

can you check if you still have the problem in trunk ?

Changed in openobject-addons:
status:	Confirmed → Incomplete

Revision history for this message

Manu (manu-tiedra) wrote on 2010-12-31:

Fabien,

I have tried in trunk and I still have the same problem.

Revision history for this message

Fabien (Open ERP) (fp-tinyerp) wrote on 2011-01-02:

to be fixed in trunk, I set the status as confirmed.

Changed in openobject-addons:
status:	Incomplete → Confirmed

Jay Vora (Serpent Consulting Services) (jayvora) on 2011-01-03

Changed in openobject-addons:
assignee:	Jay (OpenERP) (jvo-openerp) → OpenERP R&D Addons Team 2 (openerp-dev-addons2)

Kirti Savalia(OpenERP) (ksa-openerp) on 2011-01-03

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Kirti Savalia(OpenERP) (ksa-openerp) wrote on 2011-01-03:

Hello,
It has been fixed in lp:~openerp-dev/openobject-addons/ksa-addons2/
Revision NO : 3915
Revision ID: <email address hidden>

Thanks.

Changed in openobject-addons:
status:	In Progress → Fix Committed

Rucha (Open ERP) (rpa-openerp) on 2011-01-06

Changed in openobject-addons:
status:	Fix Committed → Fix Released

Revision history for this message

Manu (manu-tiedra) wrote on 2011-01-06:

Thanks for the fix. Will it be backported to v5?

I have checked the code and I think that you haven't defined the product lot field visible only to the "Usability – Extended View" group as it seems to me it is in other places...

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2011-01-07:

Thanks for the prompt response Manu.

Our policy is to keep the changes applied on stable branches to a minimum, in order to limit the regression risks for customers that are in production. This means that bugs reported on Launchpad are fixed in the trunk branch only by default, even if they were reported against other stable versions.

We stand of course ready to backport the change to stable releases if it has an impact on any customer. In this case please report it to our maintenance team via the OpenERP Publisher's Warranty. They will quickly help solve the issue and backport the fix if needed.

Thank you for your understanding!

Rucha (Open ERP) (rpa-openerp) on 2011-01-13