Odoo Addons (MOVED TO GITHUB)

[6.0] performance issues - stock_move, account_move_lines and others

Bug #693833 reported by Ferdinand
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 1
Odoo Addons (MOVED TO GITHUB) 6.0

Bug Description

1) many analysis reports use a date field to select month,month-1, year etc

IMHO stock_move and others (account_move_line) will need an index such a date field.

2) multi_company

IMHO all indices to perform well should be
company_id, field_name

I think there should be no queries without using company_id in the sql-query.

Suggestion - automatically create indices with company_id + field_name if company_id exists in the table.

Related branches

lp://staging/~openerp-commiter/openobject-addons/dev-addons2-rha1
OpenERP Core Team: Pending requested
Diff: 847 lines (+137/-98)
39 files modified
account/report/account_balance.py (+2/-0)
account/wizard/account_automatic_reconcile.py (+4/-1)
account/wizard/account_change_currency.py (+3/-3)
account/wizard/account_chart.py (+7/-7)
account/wizard/account_fiscalyear_close.py (+4/-1)
account/wizard/account_fiscalyear_close_state.py (+3/-3)
account/wizard/account_invoice_refund.py (+5/-1)
account/wizard/account_move_bank_reconcile.py (+4/-4)
account/wizard/account_move_journal.py (+1/-1)
account/wizard/account_move_line_reconcile_select.py (+3/-3)
account/wizard/account_move_line_unreconcile_select.py (+3/-3)
account/wizard/account_open_closed_fiscalyear.py (+2/-0)
account/wizard/account_reconcile.py (+8/-8)
account/wizard/account_report_balance_sheet.py (+2/-1)
account/wizard/account_report_common.py (+4/-1)
account/wizard/account_report_general_ledger.py (+1/-1)
account/wizard/account_report_partner_balance.py (+1/-1)
account/wizard/account_report_partner_ledger.py (+1/-1)
account/wizard/account_report_profit_loss.py (+1/-1)
account/wizard/account_tax_chart.py (+9/-9)
account/wizard/account_validate_account_move.py (+3/-0)
account/wizard/account_vat.py (+3/-0)
account_analytic_plans/wizard/account_crossovered_analytic.py (+3/-1)
account_coda/wizard/account_coda_import.py (+10/-10)
account_followup/wizard/account_followup_print.py (+2/-2)
account_invoice_layout/report/special_message_invoice.py (+4/-1)
auction/wizard/auction_lots_invoice.py (+2/-2)
hr_recruitment/wizard/hr_recruitment_phonecall.py (+5/-5)
hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py (+9/-9)
lunch/wizard/lunch_order_confirm.py (+2/-2)
point_of_sale/wizard/pos_payment.py (+3/-0)
point_of_sale/wizard/pos_return.py (+2/-2)
product/wizard/product_price.py (+2/-0)
product_margin/product_margin_view.xml (+3/-0)
project/wizard/project_task_delegate.py (+2/-0)
project_gtd/wizard/project_gtd_fill.py (+3/-3)
project_long_term/wizard/project_compute_phases.py (+5/-5)
project_long_term/wizard/project_compute_tasks.py (+2/-2)
stock/wizard/stock_move.py (+4/-4)
OpenERP Core Team: Pending requested
Diff: 238 lines (+35/-12)
16 files modified
account/report/account_balance.py (+2/-0)
account/wizard/account_move_journal.py (+1/-1)
account/wizard/account_open_closed_fiscalyear.py (+2/-0)
account/wizard/account_report_balance_sheet.py (+2/-1)
account/wizard/account_report_common.py (+4/-1)
account/wizard/account_report_general_ledger.py (+1/-1)
account/wizard/account_report_partner_balance.py (+1/-1)
account/wizard/account_report_partner_ledger.py (+1/-1)
account/wizard/account_report_profit_loss.py (+1/-1)
account/wizard/account_validate_account_move.py (+3/-0)
account/wizard/account_vat.py (+3/-0)
auction/wizard/auction_lots_invoice.py (+2/-2)
mrp/mrp.py (+2/-1)
product/pricelist.py (+1/-1)
stock/stock.py (+8/-0)
stock/wizard/stock_invoice_onshipping.py (+1/-1)
lp://staging/~openerp-commiter/openobject-addons/trunk-dev-addons3-psi2
Purnendu Singh (OpenERP): Needs Resubmitting
Mustufa Rangwala (Open ERP): Needs Fixing
Diff: 66 lines (+22/-2)
4 files modified
hr/security/hr_security.xml (+8/-0)
hr_evaluation/hr_evaluation_demo.xml (+7/-1)
hr_expense/security/ir_rule.xml (+1/-1)
hr_payroll/security/hr_security.xml (+6/-0)
lp://staging/~openerp-dev/openobject-addons/jam-dev-addons
OpenERP Core Team: Pending requested
Diff: 28 lines (+4/-3)
2 files modified
survey/survey.py (+1/-1)
survey/wizard/survey_answer.py (+3/-2)
Revision history for this message
Ferdinand (office-chricar) wrote :

if the company_id field is not mandatory may be a better index is (field_name,company_id)

Revision history for this message
Ferdinand (office-chricar) wrote :

reading this it might not be necessary to have include company_id
http://www.postgresql.org/docs/8.4/interactive/indexes-bitmap-scans.html

nevertheless anylsys reports tend do do full table scans
hence for very big tables (20.000 records in account_move_line use 0.1 second)
* auto search should be turned off
* a reasonable default filter should be set and the query plan must be examinend

Amit Parik (amit-parik)
Changed in openobject-addons:
status: New → Triaged
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

We Let the Addons2 team decide.

Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
Rifakat Husen (OpenERP) (rha-openerp)
Changed in openobject-addons:
status: Triaged → In Progress
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hello,

It has been fixed in lp:~openerp-commiter/openobject-addons/dev-addons2-rha1
with
Revision ID: <email address hidden>
and
Revision no: 4483

Thanks for reporting.

Changed in openobject-addons:
status: In Progress → Fix Committed
Rucha (Open ERP) (rpa-openerp)
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 2 (openerp-dev-addons2) → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
status: Fix Committed → Confirmed
Purnendu Singh (OpenERP) (purnendu-singh)
Changed in openobject-addons:
status: Confirmed → In Progress
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
importance: Undecided → Medium
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello,

We have fixed the problem in lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-psi2

Revision no: 4618
Revision ID: <email address hidden>

Thanks for reporting.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

@Puenednu: there is one problem in your diff, i can not install account.

SyntaxError: keyword argument repeated

Changed in openobject-addons:
milestone: none → 6.0
status: Fix Committed → Confirmed
Purnendu Singh (OpenERP) (purnendu-singh)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

it is working fine now Addons3 with your latest merge.

I have merged it in addons3 with:
revision-id: mra@mra-laptop-20110117123659-t3etytigbjtd88uq

thanks,
mra

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

I request Addons1 team to check for related changes.

thanks
mra

Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
status: In Progress → Confirmed
Jigar A. (ifixthat)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Jigar A. (ifixthat) wrote :

Hello,
       Fixes from add-ons modules have been done and committed to the lp:~openerp-dev/openobject-addons/jam-dev-addons.
       Revision No : 4046
Thank You

Changed in openobject-addons:
status: In Progress → Fix Committed
Bhumika Shrimali (sbh-openerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.