webkit_report zero margin support

Bug #670316 reported by Nicolas Bessi - Camptocamp
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
New
Low
Unassigned

Bug Description

Hello,
In the report_webkit module we can not take 0.0 margin in account in webkit header.
0 float is Interpreted as False. The idea will be to add a check box "no margin" on the webkit header object for each margin.
If you agree with the solution I will propose a merge proposal.

Regards

Nicolas

Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello Nicolas,

Thank you for your suggestion! However this is unfortunately out of the scope of the current OpenERP release, so we cannot implement it.
(+ reason if there is an obvious one)
Let's close this bug for now, for the sake of clarity in Launchpad, it can always be reopened later when we consider new features for future roadmaps.

Thank you for your understanding!

Changed in openobject-addons:
importance: Undecided → Wishlist
status: New → Won't Fix
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello Nicolas,

I think you right we can make this as improvement.

Thanks.

Changed in openobject-addons:
importance: Wishlist → Low
status: Won't Fix → Confirmed
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 2 (openerp-dev-addons2) → Nicolas Bessi - Camptocamp (nbessi-c2c)
Changed in openobject-addons:
status: Confirmed → Invalid
Revision history for this message
Olivier Macchioni (olivier-macchioni) wrote :

Patch attached - tested against OpenERP 5.1 / c2c_webkit_report

Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :

Can I ask why it's have Invalid status. I have same issue and always to set 0.01 margins is not cleaver. I suggest to take Olivier patch and merge it at least to a newest release.

Changed in openobject-addons:
status: Invalid → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.