[6.0][account] user can't validate the invoice of an other company; patch included
Bug #651426 reported by
Raphaël Valyi - http://www.akretion.com
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Medium
|
OpenERP R&D Addons Team 3 | ||
Bug Description
Hello,
using last trunk addons rev #5030, suppose you create two charts of account properly for two different companies (may be fix https:/
Then, using the admin user from OpenERP S.A., create an invoice for Shop 1 (I did it through a new sale order).
Make sure to parameter the customer account properly (in Shop 1) and select an appropriate period (related to Shop 1).
Actually the invoice could be made by a user belonging to Shop 1, that would just makes it easier in general.
But, the point is, once this invoice is properly created for Shop 1, no OpenERP S.A. user can properly validate this invoice. I think this would however be a classical workflow where a single accountant will manage the invoices of two companies.
Currently, when admin will try to validate the invoice, the created account.move.line will try to have their company_id to OpenERP S.A. instead of Shop 1. Consequently, the account.move.line _check_company_id constraint will fail and the invoice can't be created.
I propose the following attached patch that fixes the issues: if the account move line belongs to some move that have a company_id set, then it will use that company_id. In our case, the move is created properly for Shop 1, so applying the patch makes the account move line use Shop 1 too and the invoice to validate properly.
Hope this helps.
Related branches
lp://staging/~openerp-dev/openobject-addons/trunk-dev-addons3
- xrg (community): Needs Fixing
-
Diff: 22835 lines (+5012/-2265)319 files modifiedaccount/account.py (+28/-8)
account/account_analytic_line.py (+0/-2)
account/account_bank_statement.py (+21/-0)
account/account_installer.xml (+1/-1)
account/account_invoice_view.xml (+0/-1)
account/account_move_line.py (+14/-7)
account/account_report.xml (+1/-0)
account/account_view.xml (+12/-18)
account/board_account_view.xml (+1/-0)
account/i18n/account.pot (+13/-1)
account/i18n/ar.po (+13/-1)
account/i18n/bg.po (+14/-2)
account/i18n/br.po (+13/-1)
account/i18n/bs.po (+13/-1)
account/i18n/ca.po (+13/-2)
account/i18n/cs.po (+13/-1)
account/i18n/da.po (+13/-1)
account/i18n/de.po (+13/-2)
account/i18n/el.po (+13/-2)
account/i18n/en_US.po (+12/-0)
account/i18n/es.po (+13/-3)
account/i18n/es_AR.po (+13/-3)
account/i18n/es_EC.po (+14/-2)
account/i18n/et.po (+13/-1)
account/i18n/eu.po (+13/-1)
account/i18n/fa.po (+13/-1)
account/i18n/fi.po (+14/-2)
account/i18n/fr.po (+13/-3)
account/i18n/fr_BE.po (+13/-1)
account/i18n/gl.po (+13/-1)
account/i18n/gu.po (+13/-1)
account/i18n/he.po (+13/-1)
account/i18n/hi.po (+13/-1)
account/i18n/hr.po (+13/-1)
account/i18n/hu.po (+13/-1)
account/i18n/id.po (+13/-1)
account/i18n/it.po (+13/-3)
account/i18n/kab.po (+13/-1)
account/i18n/ko.po (+14/-2)
account/i18n/lt.po (+13/-1)
account/i18n/lv.po (+14/-2)
account/i18n/mn.po (+13/-1)
account/i18n/nb.po (+13/-1)
account/i18n/nl.po (+13/-2)
account/i18n/nl_BE.po (+13/-1)
account/i18n/oc.po (+13/-1)
account/i18n/pl.po (+13/-2)
account/i18n/pt.po (+14/-2)
account/i18n/pt_BR.po (+14/-2)
account/i18n/ro.po (+13/-2)
account/i18n/ru.po (+14/-2)
account/i18n/si.po (+13/-1)
account/i18n/sk.po (+13/-1)
account/i18n/sl.po (+14/-2)
account/i18n/sq.po (+13/-1)
account/i18n/sr.po (+13/-1)
account/i18n/sr@latin.po (+13/-1)
account/i18n/sv.po (+14/-2)
account/i18n/ta.po (+13/-1)
account/i18n/te.po (+13/-1)
account/i18n/th.po (+13/-1)
account/i18n/tlh.po (+13/-1)
account/i18n/tr.po (+14/-2)
account/i18n/ug.po (+13/-1)
account/i18n/uk.po (+13/-1)
account/i18n/vi.po (+13/-1)
account/i18n/zh_CN.po (+14/-2)
account/i18n/zh_HK.po (+13/-1)
account/i18n/zh_TW.po (+14/-2)
account/invoice.py (+19/-11)
account/report/__init__.py (+0/-2)
account/report/account_balance.py (+1/-0)
account/report/account_entries_report.py (+13/-17)
account/report/account_entries_report_view.xml (+3/-3)
account/report/account_general_ledger.py (+3/-1)
account/report/account_invoice_report_view.xml (+1/-0)
account/report/account_voucher_print.py (+0/-69)
account/report/account_voucher_print.rml (+0/-470)
account/res_currency.py (+4/-1)
account/security/ir.model.access.csv (+1/-0)
account/test/account_bank_statement.yml (+2/-2)
account/test/account_cash_statement.yml (+2/-2)
account/test/account_customer_invoice.yml (+1/-1)
account/test/account_period_close.yml (+4/-4)
account/test/account_report.yml (+6/-14)
account/test/account_validate_account_move.yml (+6/-6)
account/test/chart_of_account.yml (+2/-2)
account/wizard/account_open_closed_fiscalyear.py (+1/-1)
account/wizard/account_tax_chart_view.xml (+1/-1)
account_budget/account_budget.py (+1/-1)
account_budget/account_budget_view.xml (+2/-2)
account_budget/test/account_budget.yml (+7/-7)
account_followup/report/account_followup_report.py (+1/-2)
account_followup/test/account_followup.yml (+3/-2)
account_followup/wizard/account_followup_print.py (+8/-5)
account_payment/test/account_payment.yml (+2/-2)
account_voucher/account_voucher.py (+7/-3)
account_voucher/security/ir.model.access.csv (+2/-0)
account_voucher/voucher_sales_purchase_view.xml (+2/-2)
auction/test/auction.yml (+6/-6)
auction/test/auction_wizard.yml (+8/-8)
base_calendar/test/base_calendar_test.yml (+6/-6)
crm/test/test_crm_meeting.yml (+5/-3)
crm/test/test_crm_opportunity.yml (+4/-4)
crm/test/test_crm_phonecall.yml (+5/-4)
crm_claim/test/test_crm_claim.yml (+1/-1)
crm_helpdesk/crm_helpdesk_demo.xml (+4/-4)
crm_helpdesk/test/test_crm_helpdesk.yml (+1/-1)
delivery/test/delivery_report.yml (+3/-3)
event/test/test_event.yml (+2/-2)
hr_attendance/test/test_hr_attendance.yml (+2/-2)
hr_contract/test/test_hr_contract.yml (+4/-4)
hr_evaluation/hr_evaluation.py (+1/-1)
hr_evaluation/test/test_hr_evaluation.yml (+2/-2)
hr_expense/hr_expense_demo.xml (+6/-6)
hr_expense/test/test_hr_expense.yml (+2/-2)
hr_holidays/hr_holidays_view.xml (+2/-2)
hr_holidays/test/test_hr_holiday.yml (+4/-4)
hr_payroll/hr_payroll.py (+4/-4)
hr_payroll/hr_payroll_data.xml (+3/-3)
hr_payroll/hr_payroll_demo.xml (+2/-2)
hr_payroll/hr_payroll_view.xml (+0/-2)
hr_payroll/i18n/de.po (+2/-2)
hr_payroll/i18n/es.po (+2/-2)
hr_payroll/i18n/et.po (+2/-2)
hr_payroll/i18n/fr.po (+2/-2)
hr_payroll/i18n/hr.po (+2/-2)
hr_payroll/i18n/hr_payroll.pot (+2/-2)
hr_payroll/i18n/hu.po (+2/-2)
hr_payroll/i18n/it.po (+2/-2)
hr_payroll/i18n/mn.po (+2/-2)
hr_payroll/i18n/nl.po (+2/-2)
hr_payroll/i18n/pl.po (+2/-2)
hr_payroll/i18n/pt.po (+2/-2)
hr_payroll/i18n/ru.po (+2/-2)
hr_payroll/i18n/sr@latin.po (+2/-2)
hr_payroll/i18n/sv.po (+2/-2)
hr_payroll/i18n/zh_CN.po (+2/-2)
hr_payroll/test/payment_advice.yml (+2/-2)
hr_payroll/test/payroll_register.yml (+3/-3)
hr_payroll/test/payslip.yml (+2/-2)
hr_recruitment/test/test_hr_recruitment.yml (+3/-3)
hr_timesheet/test/test_hr_timesheet.yml (+5/-4)
hr_timesheet_invoice/report/account_analytic_profit.rml (+1/-1)
hr_timesheet_invoice/test/test_hr_timesheet_invoice.yml (+1/-1)
hr_timesheet_invoice/wizard/hr_timesheet_analytic_profit.py (+1/-1)
hr_timesheet_invoice/wizard/hr_timesheet_analytic_profit_view.xml (+3/-3)
hr_timesheet_sheet/hr_timesheet_sheet.py (+1/-1)
hr_timesheet_sheet/hr_timesheet_sheet_view.xml (+15/-1)
hr_timesheet_sheet/i18n/ar.po (+1/-5)
hr_timesheet_sheet/i18n/bg.po (+1/-5)
hr_timesheet_sheet/i18n/bs.po (+1/-5)
hr_timesheet_sheet/i18n/ca.po (+1/-5)
hr_timesheet_sheet/i18n/cs.po (+1/-5)
hr_timesheet_sheet/i18n/de.po (+1/-5)
hr_timesheet_sheet/i18n/el.po (+1/-5)
hr_timesheet_sheet/i18n/es.po (+1/-5)
hr_timesheet_sheet/i18n/es_AR.po (+1/-5)
hr_timesheet_sheet/i18n/et.po (+1/-5)
hr_timesheet_sheet/i18n/fi.po (+1/-5)
hr_timesheet_sheet/i18n/fr.po (+1/-5)
hr_timesheet_sheet/i18n/hr.po (+1/-5)
hr_timesheet_sheet/i18n/hr_timesheet_sheet.pot (+1/-5)
hr_timesheet_sheet/i18n/hu.po (+1/-5)
hr_timesheet_sheet/i18n/id.po (+1/-5)
hr_timesheet_sheet/i18n/it.po (+1/-5)
hr_timesheet_sheet/i18n/ko.po (+1/-5)
hr_timesheet_sheet/i18n/lt.po (+1/-5)
hr_timesheet_sheet/i18n/lv.po (+1/-5)
hr_timesheet_sheet/i18n/mn.po (+1/-5)
hr_timesheet_sheet/i18n/nl.po (+1/-5)
hr_timesheet_sheet/i18n/nl_BE.po (+1/-7)
hr_timesheet_sheet/i18n/pl.po (+1/-5)
hr_timesheet_sheet/i18n/pt.po (+1/-5)
hr_timesheet_sheet/i18n/pt_BR.po (+1/-5)
hr_timesheet_sheet/i18n/ro.po (+1/-5)
hr_timesheet_sheet/i18n/ru.po (+1/-5)
hr_timesheet_sheet/i18n/sl.po (+1/-5)
hr_timesheet_sheet/i18n/sq.po (+1/-5)
hr_timesheet_sheet/i18n/sv.po (+1/-5)
hr_timesheet_sheet/i18n/tlh.po (+1/-5)
hr_timesheet_sheet/i18n/tr.po (+1/-5)
hr_timesheet_sheet/i18n/uk.po (+1/-5)
hr_timesheet_sheet/i18n/vi.po (+1/-5)
hr_timesheet_sheet/i18n/zh_CN.po (+1/-5)
hr_timesheet_sheet/i18n/zh_TW.po (+1/-5)
hr_timesheet_sheet/security/ir.model.access.csv (+1/-0)
hr_timesheet_sheet/test/test_hr_timesheet_sheet.yml (+8/-8)
idea/test/test_idea.yml (+1/-1)
l10n_br/i18n/de.po (+29/-0)
l10n_br/i18n/en_US.po (+29/-0)
l10n_br/i18n/fr.po (+29/-0)
l10n_br/i18n/l10n_br.pot (+29/-0)
l10n_cn/i18n/de.po (+36/-0)
l10n_cn/i18n/en_US.po (+36/-0)
l10n_cn/i18n/fr.po (+36/-0)
l10n_cn/i18n/l10n_cn.pot (+36/-0)
l10n_cr/i18n/de.po (+159/-0)
l10n_cr/i18n/en_US.po (+159/-0)
l10n_cr/i18n/fr.po (+159/-0)
l10n_cr/i18n/l10n_cr.pot (+159/-0)
l10n_de/account_chart_skr04.xml (+34/-34)
l10n_ec/account_chart.xml (+12/-12)
l10n_ec/i18n/de.po (+35/-0)
l10n_ec/i18n/en_US.po (+35/-0)
l10n_ec/i18n/fr.po (+35/-0)
l10n_ec/i18n/l10n_ec.pot (+35/-0)
l10n_fr/plan_comptable_general_demo.xml (+185/-185)
l10n_in/l10n_in_chart.xml (+1/-1)
l10n_it/data/account.account.template.csv (+233/-233)
l10n_it/i18n/de.po (+155/-0)
l10n_it/i18n/en_US.po (+155/-0)
l10n_it/i18n/fr.po (+155/-0)
l10n_it/i18n/l10n_it.pot (+155/-0)
l10n_mx/account_chart.xml (+1/-1)
l10n_mx/i18n/de.po (+33/-0)
l10n_mx/i18n/en_US.po (+33/-0)
l10n_mx/i18n/fr.po (+33/-0)
l10n_mx/i18n/l10n_mx.pot (+33/-0)
l10n_nl/i18n/de.po (+54/-0)
l10n_nl/i18n/en_US.po (+54/-0)
l10n_nl/i18n/fr.po (+54/-0)
l10n_nl/i18n/l10n_nl.pot (+54/-0)
l10n_pl/account_chart.xml (+1/-1)
l10n_pl/i18n/de.po (+39/-0)
l10n_pl/i18n/en_US.po (+39/-0)
l10n_pl/i18n/fr.po (+39/-0)
l10n_pl/i18n/l10n_pl.pot (+39/-0)
l10n_ro/account_chart.xml (+6/-6)
l10n_ro/i18n/de.po (+48/-0)
l10n_ro/i18n/en_US.po (+48/-0)
l10n_ro/i18n/fr.po (+48/-0)
l10n_ro/i18n/l10n_ro.pot (+48/-0)
l10n_th/account_data.xml (+4/-4)
l10n_th/i18n/de.po (+35/-0)
l10n_th/i18n/en_US.po (+35/-0)
l10n_th/i18n/fr.po (+35/-0)
l10n_th/i18n/l10n_th.pot (+35/-0)
l10n_uk/l10n_uk_chart.xml (+1/-1)
l10n_ve/account_chart.xml (+2/-2)
l10n_ve/i18n/de.po (+39/-0)
l10n_ve/i18n/en_US.po (+39/-0)
l10n_ve/i18n/fr.po (+39/-0)
l10n_ve/i18n/l10n_ve.pot (+39/-0)
lunch/test/test_lunch.yml (+2/-2)
membership/membership_view.xml (+0/-1)
membership/test/test_membership.yml (+22/-22)
mrp/mrp.py (+1/-1)
mrp/test/mrp_phantom_bom.yml (+27/-27)
mrp/test/mrp_procurement.yml (+2/-2)
mrp/test/mrp_production_order.yml (+5/-5)
mrp_jit/test/mrp_jit.yml (+3/-3)
mrp_operations/test/mrp_operations.yml (+13/-13)
mrp_repair/test/test_mrp_repair.yml (+14/-14)
mrp_subproduct/test/mrp_subproduct.yml (+1/-1)
multi_company/multi_company_demo.xml (+4/-0)
point_of_sale/point_of_sale_demo.xml (+15/-15)
point_of_sale/report/pos_sales_user.py (+1/-2)
point_of_sale/report/pos_users_product.py (+2/-2)
point_of_sale/test/point_of_sale_report.yml (+2/-2)
point_of_sale/test/point_of_sale_test.yml (+15/-7)
project/project.py (+1/-1)
project/test/test_project.yml (+7/-7)
project_long_term/test/schedule_phase_tasks.yml (+1/-1)
project_long_term/test/schedule_project_phases.yml (+62/-62)
project_long_term/test/schedule_project_tasks.yml (+1/-1)
project_mrp/test/project_task_procurement.yml (+1/-1)
project_planning/test/planning_states.yml (+2/-2)
project_retro_planning/test/deadline_change.yml (+3/-3)
project_timesheet/test/worktask_entry_to_timesheetline_entry.yml (+31/-31)
purchase/purchase.py (+2/-2)
purchase/purchase_demo.xml (+3/-3)
purchase/test/procurement_buy.yml (+18/-18)
purchase/test/purchase_from_manual.yml (+2/-2)
purchase/test/purchase_from_order.yml (+12/-12)
purchase/test/purchase_from_picking.yml (+4/-3)
purchase_requisition/purchase_requisition_demo.xml (+1/-1)
purchase_requisition/test/purchase_requisition.yml (+39/-39)
purchase_requisition/test/purchase_requisition_exclusive.yml (+24/-24)
resource/resource.py (+1/-1)
sale/test/advance_invoice.yml (+11/-11)
sale/test/invoice_on_ordered_qty.yml (+12/-12)
sale/test/invoice_on_shipped_qty.yml (+13/-12)
sale/test/manual_order_policy.yml (+2/-2)
sale/test/picking_order_policy.yml (+14/-13)
sale/test/postpaid_order_policy.yml (+23/-23)
sale/test/prepaid_order_policy.yml (+11/-11)
sale/test/sale_procurement.yml (+5/-5)
sale/test/so_make_invoice.yml (+3/-3)
sale/test/so_make_line_invoice.yml (+14/-14)
sale_margin/test/sale_margin.yml (+2/-2)
sale_mrp/test/sale_mrp.yml (+4/-4)
stock/stock.py (+2/-2)
stock/test/stock_test.yml (+97/-97)
stock_invoice_directly/test/stock_invoice_directly.yml (+11/-11)
stock_location/test/stock_location_pull_flow.yml (+47/-47)
stock_location/test/stock_location_push_flow.yml (+17/-17)
stock_no_autopicking/test/stock_no_autopicking.yml (+2/-2)
stock_planning/test/stock_planning.yml (+28/-28)
survey/i18n/bg.po (+1/-1)
survey/i18n/cs.po (+1/-1)
survey/i18n/de.po (+1/-1)
survey/i18n/es.po (+1/-1)
survey/i18n/et.po (+1/-1)
survey/i18n/fr.po (+2/-2)
survey/i18n/hr.po (+1/-1)
survey/i18n/mn.po (+1/-1)
survey/i18n/nl.po (+1/-1)
survey/i18n/pl.po (+1/-1)
survey/i18n/pt.po (+1/-1)
survey/i18n/ru.po (+1/-1)
survey/i18n/sl.po (+1/-1)
survey/i18n/sr.po (+1/-1)
survey/i18n/sr@latin.po (+1/-1)
survey/i18n/survey.pot (+1/-1)
survey/i18n/sv.po (+1/-1)
survey/i18n/zh_CN.po (+1/-1)
survey/survey.py (+1/-1)
survey/survey_demo.xml (+34/-34)
Revision history for this message
| Raphaël Valyi - http://www.akretion.com (rvalyi) wrote | #1 |
| summary: |
- [6.0][account] user can't validate the invoice of an other company + [6.0][account] user can't validate the invoice of an other company; + patch included |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3) |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
| Changed in openobject-addons: | |
| milestone: | 6.0 → 6.0-rc2 |
Revision history for this message
| Priyesh (OpenERP) (pso-openerp) wrote | #2 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Committed |
| Changed in openobject-addons: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hello Raphaël Valyi,
We have applied your patch in Addons3 branch.
revision-id: mra@mra-
revno: 4567
Thanks for your contribution.