slovakia vat number check problem

Bug #610855 reported by Yan-PCSol
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 3

Bug Description

The check doesn't work with this valid vat number : SK2021853504

Your check method is obsolete, update your vat number check (for example: http://code.google.com/p/vatnumber/issues/detail?id=9)
Is it no better for maintenance to use vatnumber as module instead of copy/pasting the code?

On ubuntu, the package exists: python-vatnumber

Related branches

description: updated
Changed in openobject-addons:
status: New → Confirmed
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Yannick,

I have seen that your vat is valid.

But, I'm looking for any official documentation of slovakian vat number.

Can you provide that?

Thanks.

Revision history for this message
Cédric Krier (cedk) wrote :

Why don't you trust the vatnumber library?

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Cédric,

This is not about trusting vatnumber library.

We already have used copyright and trusted the code.

I am just concerned to be accurate for this sort of official validation,so in future(if any query arises) we can show that we have followed the standard from the website.

For example, currently we can say that we have followed http://sima-pc.com/nif.php and your code.

This is not only for slovakia, it can be for any country that is yet to be vat-validated by OpenERP.

Hope this clears.

Thanks.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Base_vat related issues should be fixed only after having some documental proof/check on official websites of corresponding countries.

Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
importance: Low → Medium
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello Yannick,

We have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-
dev-addons3 branch, It will be merged soon in lp:openobject-addons.

Revision No: 4733
Revision ID: mra@mra-laptop-20101209080042-890zkauhikdorzxy

Thanks
PSI

Changed in openobject-addons:
status: In Progress → Fix Released
Revision history for this message
Cédric Krier (cedk) wrote :

Guys you really sucks. You just copy/paste codes from a library (that is available on pypi and many OS packaging) instead of using it so your code will always be less accurate and more over, you don't respect any programming common senses.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.