Odoo Addons (MOVED TO GITHUB)

Split Stock move breaks the destination moves logic logic

Bug #1269365 reported by Eric Caudal - www.elico-corp.com
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP Publisher's Warranty Team
OpenERP Community Backports (Addons)
Status tracked in 7.0
6.1
New
Undecided
Yann Papouin
7.0
New
Undecided
Unassigned

Bug Description

How to reproduce the bug
Context: have pull flow generating a 2 moves, linked together via move_dest_id field.
Create a stock picking with one move (quantity =10)
Split one stock move with new serial number
In the stock picking now there are 2 SM with same product and same move_dest_id and complementary quantities (7+3)
When processing the quantity in full, the second move in move_dest_id is still in waiting for another move

It seems due to the following code in stock/stock.py (action_done around line 2400):

            if move.move_dest_id.id and (move.state != 'done'):
                # Downstream move should only be triggered if this move is the last pending upstream move
                other_upstream_move_ids = self.search(cr, uid, [('id','!=',move.id),('state','not in',['done','cancel']),
                                            ('move_dest_id','=',move.move_dest_id.id)], context=context)
                if not other_upstream_move_ids:
                    self.write(cr, uid, [move.id], {'move_history_ids': [(4, move.move_dest_id.id)]})
                    if move.move_dest_id.state in ('waiting', 'confirmed'):
                        self.force_assign(cr, uid, [move.move_dest_id.id], context=context)
                        if move.move_dest_id.picking_id:
                            wf_service.trg_write(uid, 'stock.picking', move.move_dest_id.picking_id.id, cr)
                        if move.move_dest_id.auto_validate:
                            self.action_done(cr, uid, [move.move_dest_id.id], context=context)

The first move will always find the second move as other_upstream_move_ids and the last one as well so condition "not other_upstream_move_ids" never happens (as the moves are sent as done later on, outside the for loop)

Tags: maintenance

Related branches

lp://staging/~openerp-dev/openobject-addons/7.0-opw-603094-rha
Paulius Sladkevičius @ hbee (community): Approve (test)
Naresh(OpenERP): Pending requested
Diff: 35 lines (+10/-3)
1 file modified
stock/stock.py (+10/-3)
Vinay Rana (OpenERP) (vra-openerp)
Changed in openobject-addons:
assignee: nobody → OpenERP Publisher's Warranty Team (openerp-opw)
tags: added: maintenance
Rifakat Husen (OpenERP) (rha-openerp)
Changed in openobject-addons:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Low
Rifakat Husen (OpenERP) (rha-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hi,

I have fixed it in, lp:~openerp-dev/openobject-addons/7.0-opw-603094-rha
Revision 9782, <email address hidden>

Please let me know if you face any problem. I will mark this bug report as Fixed Committed.

Regards,
Rifakat

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
开阖软件 Jeff Wang (jeff.osbzr.com) wrote :

Please merge this fix as soon as possible, I face the same problem in my client's production database.

User need 2 steps delivery, so I set the output location as chain mode "manually "

Then when a new sales order been confirmed, 2 picking generated, the first one is a internal picking , then chained to an delivery order.

When user transfer the internal picking, everybody see the product on Output location, but the delivery order keep on waiting.
Click on "Check Availableb" Button returns an error message 'Not enough stock, unable to reserve the products.'

With this patch, chained delivery order can be set as "Ready" right after the internal picking is Done.

I still do not understand why only moves on "confirmed" state is been check,why not check "waiting" state also. (stock/stock.py )

    def action_assign(self, cr, uid, ids, *args):
        """ Changes state of picking to available if all moves are confirmed.
        @return: True
        """
        wf_service = netsvc.LocalService("workflow")
        for pick in self.browse(cr, uid, ids):
            if pick.state == 'draft':
                wf_service.trg_validate(uid, 'stock.picking', pick.id, 'button_confirm', cr)
            move_ids = [x.id for x in pick.move_lines if x.state == 'confirmed'] <-------- don't you think we should add "or x.state=='waiting' " ?
            if not move_ids:
                raise osv.except_osv(_('Warning!'),_('Not enough stock, unable to reserve the products.'))
            self.pool.get('stock.move').action_assign(cr, uid, move_ids)
        return True

Revision history for this message
Eric Caudal - www.elico-corp.com (elicoidal) wrote : Re: [Bug 1269365] Re: Split Stock move breaks the destination moves logic logic

It has been fixed by OPW actually
Eric CAUDAL

Eric Caudal

On 04/09/2014 02:45 PM, 开阖软件 Jeff Wang wrote:
> Please merge this fix as soon as possible, I face the same problem in my
> client's production database.
>
> User need 2 steps delivery, so I set the output location as chain mode
> "manually"
>
> Then when a new sales order been confirmed, 2 picking generated, the
> first one is a internal picking , then chained to an delivery order.
>
> When user transfer the internal picking, everybody see the product on Output location, but the delivery order keep on waiting.
> Click on "Check Availableb" Button returns an error message 'Not enough stock, unable to reserve the products.'
>
> With this patch, chained delivery order can be set as "Ready" right
> after the internal picking is Done.
>
> I still do not understand why only moves on "confirmed" state is been
> check,why not check "waiting" state also. (stock/stock.py )
>
> def action_assign(self, cr, uid, ids, *args):
> """ Changes state of picking to available if all moves are confirmed.
> @return: True
> """
> wf_service = netsvc.LocalService("workflow")
> for pick in self.browse(cr, uid, ids):
> if pick.state == 'draft':
> wf_service.trg_validate(uid, 'stock.picking', pick.id, 'button_confirm', cr)
> move_ids = [x.id for x in pick.move_lines if x.state == 'confirmed'] <-------- don't you think we should add "or x.state=='waiting' " ?
> if not move_ids:
> raise osv.except_osv(_('Warning!'),_('Not enough stock, unable to reserve the products.'))
> self.pool.get('stock.move').action_assign(cr, uid, move_ids)
> return True
>

Revision history for this message
Leonardo Donelli (learts92) wrote :

@Eric Caudal:
Are you sure? I have the addons at the latest revision (10082) and that part of the code is still identical and the bug is not fixed.

Revision history for this message
Eric Caudal - www.elico-corp.com (elicoidal) wrote :

Hi Leonardo,
I am not sure about the bugfixing from Odoo into core but we
definitively received a bug fixing here:

https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-603094-rha/+merge/203273

Hope this helps
Eric CAUDAL

Eric Caudal
/CEO/

On 07/09/2014 04:16 PM, Leonardo Donelli wrote:
> @Eric Caudal:
> Are you sure? I have the addons at the latest revision (10082) and that part of the code is still identical and the bug is not fixed.
>

Revision history for this message
Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives) wrote :

Has this been fixed ?

Revision history for this message
Eric Caudal - www.elico-corp.com (elicoidal) wrote :

Yes long time ago
Eric CAUDAL

Eric Caudal
On 11/29/2014 12:26 AM, Lionel Sausin - Numérigraphe wrote:

> Has this been fixed ?
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.