Odoo Addons (MOVED TO GITHUB)

HR Holiday remaining days unable to handle float

Bug #1259971 reported by Ludo (Neobis)
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Low
OpenERP R&D Addons Team 3
OpenERP Community Backports (Addons)
Status tracked in 7.0
7.0
New
Low
Alexandre Fayolle - camptocamp

Bug Description

In the default HR module, when making a leave request, there is a drop-down option for selecting the "Leave type" of the holiday. In this selection field, the number of days left is noted as an integer ( Legal leaver 1/10 days ), whilst the request itself counts in floats (i.e. 0.5 days off).

When you request half a day off (i.e. 0.5 days), the remaning days will not be altered (i.e. 0/10). However if the total days will be exceeded, in this case requesting 10 days off, it will still give the error.

It should be a notation of floats in the drop-down box.

Branches used:
- Server: 7.0
- Addons: 7.0

Tags: holiday hr

Related branches

lp://staging/~openerp-dev/openobject-addons/trunk-bug-1259971-ssh
Alexandre Fayolle - camptocamp (community): Needs Fixing (code review, no test)
OpenERP Core Team: Pending requested
Diff: 11 lines (+1/-1)
1 file modified
hr_holidays/hr_holidays.py (+1/-1)
lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix_1259971-ssh+afe
Holger Brunn (Therp): Approve (code review)
Stefan Rijnhart (Opener): Approve
Guewen Baconnier @ Camptocamp: Approve
Yannick Vaucher @ Camptocamp: Approve (code review, no tests)
Diff: 11 lines (+1/-1)
1 file modified
hr_holidays/hr_holidays.py (+1/-1)
lp://staging/~camptocamp/openobject-addons/7.0-fix_1259971-ssh+afe
Pedro Manuel Baeza (community): Approve (code review)
OpenERP Core Team: Pending requested
Diff: 11 lines (+1/-1)
1 file modified
hr_holidays/hr_holidays.py (+1/-1)
Twinkle Christian(OpenERP) (tch-openerp)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Twinkle Christian(OpenERP) (tch-openerp)
tags: added: holiday
removed: leave request
Sunil Sharma(OpenERP) (sunil.sharma-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Sunil Sharma(OpenERP) (sunil.sharma-openerp) wrote :

Hello,

It has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1259971-ssh

revision-id: 9050

revno: <email address hidden>

It will be available in trunk soon.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Michael Karrer (michaelkarrer81) wrote :

please merge it soon ;)

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

@michaelkarrer note that the merge is for trunk, not stable. If you really need this in stable, please backport the fix to stable and propose a merge in the ocb-addons branch.

Revision history for this message
Michael Karrer (michaelkarrer81) wrote :

@alexandre-fayolle-c2c -

Thanks for your comment. At least anyone is responding but it is the exact same fix for 7.0 too so do i really have to duplicate the related branch?

And even if i do so i lost my trust in OpenERP that anything will be merged into 7.0 - There are still a lot of bugs open with status "Fix committed" That are over two years old.

I do believe it has a chance in OCB and i will try that.

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote : Re: [Bug 1259971] Re: HR Holiday remaining days unable to handle float

On 27/02/2014 22:23, Michael Karrer wrote:
> @alexandre-fayolle-c2c -
>
> Thanks for your comment. At least anyone is responding but it is the
> exact same fix for 7.0 too so do i really have to duplicate the related
> branch?
>
> And even if i do so i lost my trust in OpenERP that anything will be
> merged into 7.0 - There are still a lot of bugs open with status "Fix
> committed" That are over two years old.
>
> I do believe it has a chance in OCB and i will try that.
>
 I'll do the backporting of the fix to 7.0 and OCB for you.

The situation of the "lots of open bugs in status Fix Committed" is what
drove us to creating the OCB branch. If the editor does not have the
ressources to actually do the merges, we, the community, will do that
work. It means people participating and giving their time for this, to
build better OpenERP branches for everyone. I hope you'll join the effort.

--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.