[trunk/7.0] POS sale details report exception when sale order lines contains no taxes

Bug #1225860 reported by Andrius Preimantas @ hbee
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Committed
Medium
OpenERP R&D Addons Team 3

Bug Description

Addons revno: 9443

This bus is introduced with this commit:
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9435

The return value of _get_tax_amount() function is used with repeatIn report tag which apparently is not aware how to cope with False value (one is returned when no taxes are generated).

Please find patch attached

Revision history for this message
Andrius Preimantas @ hbee (andrius-preimantas) wrote :
Revision history for this message
Twinkle Christian(OpenERP) (tch-openerp) wrote :
Download full text (4.8 KiB)

Hello,

I am facing this below traceback :

2013-09-16 09:47:54,800 18911 ERROR trnk openerp.service.report: Exception: "'bool' object is not iterable" while evaluating
"repeatIn(gettaxamount(data['form']), 'p')"
Traceback (most recent call last):
  File "/home/tch/workspace/rdtools/server/trunk/openerp/service/report.py", line 92, in go
    result, format = openerp.report.render_report(cr, uid, ids, object, datas, context)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/__init__.py", line 40, in render_report
    return registry['ir.actions.report.xml'].render_report(cr, uid, ids, name, data, context)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/addons/base/ir/ir_actions.py", line 129, in render_report
    return new_report.create(cr, uid, res_ids, data, context)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/report_sxw.py", line 456, in create
    fnct_ret = fnct(cr, uid, ids, data, report_xml, context)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/report_sxw.py", line 525, in create_source_pdf
    return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/report_sxw.py", line 547, in create_single_pdf
    pdf = create_doc(etree.tostring(processed_rml),rml_parser.localcontext,logo,title.encode('utf8'))
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/interface.py", line 217, in create_pdf
    obj.render()
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/render.py", line 59, in render
    self._result = self._render()
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml.py", line 41, in _render
    return rml2pdf.parseNode(self.rml, self.localcontext, images=self.bin_datas, path=self.path,title=self.title)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/trml2pdf.py", line 1035, in parseNode
    r.render(fp)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/trml2pdf.py", line 348, in render
    pt_obj.render(el)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/trml2pdf.py", line 1011, in render
    fis += r.render(node_story)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/trml2pdf.py", line 905, in render
    return process_story(node_story)
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/trml2pdf.py", line 894, in process_story
    for node in utils._child_get(node_story, self):
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/render/rml2pdf/utils.py", line 48, in _child_get
    for ctx in eval(n.get('rml_loop'),{}, self.localcontext):
  File "/home/tch/workspace/rdtools/server/trunk/openerp/tools/safe_eval.py", line 246, in safe_eval
    return eval(c, globals_dict, locals_dict)
  File "", line 1, in <module>
  File "/home/tch/workspace/rdtools/server/trunk/openerp/report/report_sxw.py", line 331, in repeatIn
    for id in lst:
ValueError: "'bool' object is not iterable" while evaluating
"repeatIn(gettaxamount(data['form']), 'p')"
2013-09-16 09:47:55,147 18911 ERROR trnk openerp.a...

Read more...

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Medium
status: New → Confirmed
summary: - [7.0] POS sale details report exception when sale order lines contains
- no taxes
+ [trunk/7.0] POS sale details report exception when sale order lines
+ contains no taxes
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mehul Mehta(OpenERP) (mehul.mehta-openerp) wrote :

Hello Andrius Preimantas,

Thanks for your patch.. i have tested ur patch it' working properly.
so it has been fixed on this https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1225860-mme with following :

    Revision ID: <email address hidden>
    Revision NO: 8902

thanks for your patch and contrbution.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Andrius Preimantas @ hbee (andrius-preimantas) wrote :

Hello, Mehul

Thanks for such fast fix, it really shows your competence.

Andrius

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.