[PoS frontend] when you receive payment, entering a number with a comma => the floats after the comma are ignored
Bug #1099404 reported by
Gilles Major (OpenERP)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Committed
|
Low
|
OpenERP R&D Addons Team 3 | ||
Bug Description
1. go to point of sale and open a session
2. select some products
3. select a journal (cash or bank)
4. enter an amount but use a comma instead of a dot ( , )
the numbers after the comma are completely ignored.
I suggest automatically converting a comma into a dot or make it so that commas can be used
video:
https:/
Related branches
lp://staging/~openerp-dev/openobject-addons/trunk-bug-1099404-fka
- OpenERP Core Team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedpoint_of_sale/static/src/js/widgets.js (+1/-1)
lp://staging/~mmakonnen/openobject-addons/point_of_sale_enhanced-70
- OpenERP Core Team: Pending requested
-
Diff: 1267 lines (+868/-4) (has conflicts)9 files modifiedpoint_of_sale/controllers/main.py (+21/-0)
point_of_sale/point_of_sale.py (+11/-2)
point_of_sale/static/src/css/pos.css (+173/-0)
point_of_sale/static/src/js/db.js (+78/-0)
point_of_sale/static/src/js/devices.js (+179/-0)
point_of_sale/static/src/js/models.js (+71/-2)
point_of_sale/static/src/js/screens.js (+113/-0)
point_of_sale/static/src/js/widgets.js (+138/-0)
point_of_sale/static/src/xml/pos.xml (+84/-0)
- OpenERP Core Team: Pending requested
-
Diff: 1181 lines (+810/-6) (has conflicts)9 files modifiedpoint_of_sale/controllers/main.py (+16/-0)
point_of_sale/point_of_sale.py (+3/-1)
point_of_sale/static/src/css/pos.css (+173/-0)
point_of_sale/static/src/js/db.js (+72/-0)
point_of_sale/static/src/js/devices.js (+179/-0)
point_of_sale/static/src/js/models.js (+65/-4)
point_of_sale/static/src/js/screens.js (+109/-0)
point_of_sale/static/src/js/widgets.js (+113/-1)
point_of_sale/static/src/xml/pos.xml (+80/-0)
Revision history for this message
| van der Essen Frédéric (OpenERP) (fva-openerp) wrote | #1 |
Revision history for this message
| van der Essen Frédéric (OpenERP) (fva-openerp) wrote | #2 |
| Changed in openobject-addons: | |
| status: | New → Confirmed |
| Changed in openobject-addons: | |
| assignee: | nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3) |
| importance: | Undecided → Low |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Foram Katharotiya (OpenERP) (fka-openerp) wrote | #3 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
We should be careful about this, commas are used to separate thousands in US and UK :
1,000,000.000 = 1000000
I think such behaviour should be based on the user's locale. Standardising on the dot seems a safer bet in the mean time.
I tried on other fields in openerp and their behaviour look broken as well : try 18,00 in a price field -> it is converted to 1800.00 wtf ?